[CAMEL-15187] fixes bug in camel-jsonpath StreamCache not reset #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jun 14, 2020
davsclaus
approved these changes
Jun 15, 2020
davsclaus
pushed a commit
that referenced
this pull request
Jun 17, 2020
* jsonpath: add failing test for StreamCache reuse * jsonpath: reset StreamCache after use * checkstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using jsonpath as a predicate in a CBR the StreamCache is not reset and therefore the content is lost. The first commit adds a failing JsonPathStreamCachingCBRTest which is just a copy of JsonPathCBRTest with streaming. The second commit adds
StreamCache.reset()s wherever it seemed appropriate after content is read.