New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x" #4367
Conversation
components/camel-saxon/pom.xml
Outdated
@@ -33,7 +33,7 @@ | |||
|
|||
<properties> | |||
<camel.osgi.import.additional> | |||
net.sf.saxon.*;version="[9.9.0,10)" | |||
net.sf.saxon.*;version="[9.9.0,11)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those API changes later would mean that we require saxon 10, 11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davsclaus can i keep only version 10
net.sf.saxon.*;version="[10.0,10.3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[10.0,10.3) means include 10.0,10.1,10.2 and exclude 10.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't makes sense to restrict to 10.3 the range. Use 11 as upper limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks oscerd. then i think there is no need to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already provided upper limit 11
net.sf.saxon.*;version="[9.9.0,11)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it should be [10,11)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, it needs to be strict [10,11)
[CAMEL-XXX] Fixes bug in camel-file component
, where you replaceCAMEL-XXX
with the appropriate JIRA issue.mvn clean install -Psourcecheck
in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md