Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x" #4367

Closed
wants to merge 0 commits into from
Closed

"CAMEL-15616:camel-saxon - Upgrade to Saxon 10.x" #4367

wants to merge 0 commits into from

Conversation

ramu11
Copy link
Contributor

@ramu11 ramu11 commented Oct 6, 2020

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
    Below are the contribution guidelines:
    https://github.com/apache/camel/blob/master/CONTRIBUTING.md

@@ -33,7 +33,7 @@

<properties>
<camel.osgi.import.additional>
net.sf.saxon.*;version="[9.9.0,10)"
net.sf.saxon.*;version="[9.9.0,11)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those API changes later would mean that we require saxon 10, 11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davsclaus can i keep only version 10
net.sf.saxon.*;version="[10.0,10.3)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[10.0,10.3) means include 10.0,10.1,10.2 and exclude 10.3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't makes sense to restrict to 10.3 the range. Use 11 as upper limit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks oscerd. then i think there is no need to change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already provided upper limit 11
net.sf.saxon.*;version="[9.9.0,11)"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it should be [10,11)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, it needs to be strict [10,11)

@ramu11 ramu11 closed this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants