AutomaticRecovery from RabbitMQ Connection Factory doesn't recover from everything #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om everything and we could just return the same closed connection over and over ...
…) again, my solution would be to stop it before
…n, we have to reconnect to it before publishing our response to it, since the current Reconnection mechanism is made only in Producer, not in Publisher
… from the messages during the conversion to AMQP properties. Thus, I use a temporar Map to keep the logic as close as it is, but without touching the Message Headers
|
I added few others improvements we made, specially when the Consumer receives a RPC Call, he can't send it back if the channel is down ... So we added a little mechanism to reconnect the channel one time before retrying to send back the reply. It allowed us to not lose any RPC call in case of connection/channel outage. |
|
Thanks for contribution. Can you please revert all unnecessary changes? You have reordered methods and fields in |
|
Damn, I overlooked that. I fix it tomorrow, sorry.
Le mer. 7 oct. 2020 à 19:50, Jan Bednar <notifications@github.com> a écrit :
… Thanks for contribution. Can you please revert all unnecessary changes?
You have reordered methods and fields in RabbitConsumer and because of
that is your PR much harder to review then it could be.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4384 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLMI2CV4QUZ4W23L4R3WALSJSS5ZANCNFSM4SHMSMHA>
.
|
|
I pushed a new commit which revert all the format changes, "Files changed" looks normal now |
davsclaus
reviewed
Oct 8, 2020
components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitConsumer.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We met a condition in production where the Connection Factory of Rabbitmq won't recover (when isAutomaticRecoveryEnabled is set to true). It's easily reproducible by calling the ".close()" method on it.
It's explained here : https://www.rabbitmq.com/api-guide.html#recovery
The current code would always returns the same connection, not re-establishing it, if isAutomaticRecoveryEnabled is enabled.
Our solution, based on the fact we just have "isOpen" to check the state of the channel/connection was to re-establish the connection in the RabbitMQConsumer even if "isAutomaticRecoveryEnabled" is enabled.
What's your thought about it ?