CAMEL-15689 - Add camel-atlasmap component #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igarashitm
force-pushed
the
camel-atlasmap
branch
2 times, most recently
from
0816227
to
efeff50
Compare
oscerd
approved these changes
Oct 15, 2020
davsclaus
approved these changes
Oct 15, 2020
aldettinger
reviewed
Oct 15, 2020
| if (!errors.isEmpty()) { | ||
| StringBuilder buf = new StringBuilder("Errors: "); | ||
| errors.stream().forEach(a -> buf.append( | ||
| String.format("[%s: Document='{}(ID:{})', path='%s'], ", |
There was a problem hiding this comment.
Do we have a mix here where last 2 params are ignored ?
There was a problem hiding this comment.
Doh good catch, thanks! fixed.
aldettinger
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
Just a small question above but otherwise looks good to me. Well done @igarashitm :)
igarashitm
force-pushed
the
camel-atlasmap
branch
from
efeff50
to
908a173
Compare
igarashitm
force-pushed
the
camel-atlasmap
branch
from
908a173
to
84ce099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CAMEL-XXX] Fixes bug in camel-file component, where you replaceCAMEL-XXXwith the appropriate JIRA issue.mvn clean install -Psourcecheckin your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md