-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camel-avro-rpc introduction of SPI for the HTTP server #5714
Conversation
When creating a middle folder for that component, then I think you need to look in the camel-maven-package-plugin that prepares the catalog (PrepareCatalogMojo), that it needs to deal with this. Try to git grep camel-salesforce etc that is also a middle folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first sight this requires some work at catalog level. The removal of avro component from catalog seems to be wrong.
@oscerd my idea was to move avro-component module to sub-folder without changing any link to catalog. If there is some configuration needed here, I'll add it. May I ask you for the help? Is it the |
Yes its that maven plugin |
There is a switch https://github.com/apache/camel/blob/main/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java#L575 And you need to go down the directory to get the documentation. |
Thanks a lot. I'll fix it |
b138c80
to
80743b7
Compare
I forgot to fix the doc. I'll do it. |
80743b7
to
a4e1d9a
Compare
a4e1d9a
to
0c5e14c
Compare
@oscerd @davsclaus Catalog problem is fixed. |
Issues: https://issues.apache.org/jira/browse/CAMEL-16740
This PR introduces a new spi api for camel-avro-rpc, which allows to switch implementation of the HTTP server.
It moves current module into new location
camel-avro-rpc/camel-avro-rpc
and adds 2 new modules:components/camel-avro-rpc/camel-avro-rpc-spi
and
components/camel-avro-rpc/camel-avro-rpc-jetty
.High picture:
Component (in
AvroListener
) usesorg.apache.camel.component.avro.spi.AvroRpcHttpServerBuilder
as a spi interface (fromcamel-avro-rpc-spi
) for creation of http server.Module
camel-avro-rpc-jetty
contains implementation of this interface in the way it was before - using jetty http server. This module is used by compinent by default.Nothing changes from the user point of view .