Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAMEL-17310] Add dev goal to enable live reloading #6522

Merged
merged 1 commit into from Dec 12, 2021

Conversation

Croway
Copy link
Contributor

@Croway Croway commented Dec 10, 2021

As discussed in https://issues.apache.org/jira/browse/CAMEL-17310 there are some issues with live reload, I'll try to investigate more

@davsclaus
Copy link
Contributor

The fileWatcherDirectory was the old name, we can give it a better and shorter name.

Also I think the plugin should default to reload automatic, and automatic select the src/main/resources directory.
There is a way via a maven plugin to get hold of "resource directory" but I guess that 99% its always src/main/resources anyway.

For java routes then its a bit more tricky as they would be in src/main/java. So we can in the future have some kind of watcher that automatic detects all .java source files and whether they are Camel routes.

@Croway
Copy link
Contributor Author

Croway commented Dec 11, 2021

The fileWatcherDirectory was the old name, we can give it a better and shorter name.

Also I think the plugin should default to reload automatic, and automatic select the src/main/resources directory. There is a way via a maven plugin to get hold of "resource directory" but I guess that 99% its always src/main/resources anyway.

For java routes then its a bit more tricky as they would be in src/main/java. So we can in the future have some kind of watcher that automatic detects all .java source files and whether they are Camel routes.

Thanks, I have implemented your comment, moreover I had to do some changes to RouteWatcherReloadStrategy in order to handle recursive live reload, and I did some changes in case of file removal.

@davsclaus davsclaus merged commit 1d6404a into apache:main Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants