CAMEL-17373: Fix FhirComponent startup #6629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 4, 2022
davsclaus
approved these changes
Jan 4, 2022
orpiske
reviewed
Jan 4, 2022
Comment on lines
51
to
52
| if (endpointConfiguration.getClient() == null && configuration.getClient() == null) { | ||
| if (configuration != null) { |
There was a problem hiding this comment.
I apologize if I am missing context, but by looking at it, it seems that the configuration variable could be null. In which case, it would throw an NPE at line 51. Maybe it should fail right away by adding a pre-check with ObjectHelper::notNull ?
There was a problem hiding this comment.
many thanks @orpiske ! actually no test were failing due to NPE, but I noticed that all tests were using a custom FhirComponent, if someone use the default one, NPE will happend, I just created a new test for this usecase FhirSimpleIT.java
There was a problem hiding this comment.
Thanks for double-checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.