New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-17474: camel-core - set transacted when copying exchange in mul… #7040
Conversation
core/camel-core-processor/src/main/java/org/apache/camel/processor/MulticastProcessor.java
Show resolved
Hide resolved
Doesn't seem to solve the issue when using spring transactions. Not sure if it's supposed to. |
@jeremyross yeah, I think it could reslove the issue when using spring transactions. |
d5723b3
to
10e4cbd
Compare
@davsclaus I add a similar fix for RecipientList and Split EIP. This issue only happens when it copies the exchange and sends it to more then one sub-route in the transacted context. |
Can you add a test for the Enricher EIP also. |
Sure, I will do. |
@zhfeng ok just tested with my reproducer project and it looks like it does fix the problem. |
Thanks @jeremyross for checking it ! |
tests/camel-itest/src/test/java/org/apache/camel/itest/tx/JtaRouteTest.java
Show resolved
Hide resolved
Sorry can you make this PR compile with JDK8 also so we can backport this to older branches |
Oh, I just missed it. |
We removed the CI build for JDK 8 ? |
There are CI for 3.14 and 3.11 branches. |
Though the PR may work with JDK8 .. I frankly may be mistaken. We can see when we backport as you will get CI errors then |
OK, I will check it with JDK8 locally before backport it to 3.14 and 3.11 |
apache#7040) * CAMEL-17474: camel-core - set transacted when copying exchange in multicast processor * CAMEL-17474: camel-core - similar fix with RecipientList and Split EIP * CAMEL-17474: add a test for Enrich EIP * CAMEL-17474 add assertions to check the copied exchanges are marked as transactional
#7040) * CAMEL-17474: camel-core - set transacted when copying exchange in multicast processor * CAMEL-17474: camel-core - similar fix with RecipientList and Split EIP * CAMEL-17474: add a test for Enrich EIP * CAMEL-17474 add assertions to check the copied exchanges are marked as transactional
@davsclaus It works with JDK 8 and I just backport to 3.14.x |
apache#7040) * CAMEL-17474: camel-core - set transacted when copying exchange in multicast processor * CAMEL-17474: camel-core - similar fix with RecipientList and Split EIP * CAMEL-17474: add a test for Enrich EIP * CAMEL-17474 add assertions to check the copied exchanges are marked as transactional
…ticast processor
another fix in MultiProcessor.