Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-17474: camel-core - set transacted when copying exchange in mul… #7040

Merged
merged 4 commits into from Mar 1, 2022

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Feb 25, 2022

…ticast processor

another fix in MultiProcessor.

@jeremyross
Copy link
Contributor

Doesn't seem to solve the issue when using spring transactions. Not sure if it's supposed to.

@zhfeng
Copy link
Contributor Author

zhfeng commented Feb 28, 2022

@jeremyross yeah, I think it could reslove the issue when using spring transactions.

@zhfeng
Copy link
Contributor Author

zhfeng commented Feb 28, 2022

@davsclaus I add a similar fix for RecipientList and Split EIP. This issue only happens when it copies the exchange and sends it to more then one sub-route in the transacted context.

@davsclaus
Copy link
Contributor

Can you add a test for the Enricher EIP also.

@zhfeng
Copy link
Contributor Author

zhfeng commented Feb 28, 2022

Sure, I will do.

@jeremyross
Copy link
Contributor

@zhfeng ok just tested with my reproducer project and it looks like it does fix the problem.

@zhfeng
Copy link
Contributor Author

zhfeng commented Feb 28, 2022

Thanks @jeremyross for checking it !

@davsclaus
Copy link
Contributor

Sorry can you make this PR compile with JDK8 also so we can backport this to older branches

@zhfeng
Copy link
Contributor Author

zhfeng commented Mar 1, 2022

Oh, I just missed it.

@zhfeng
Copy link
Contributor Author

zhfeng commented Mar 1, 2022

We removed the CI build for JDK 8 ?

@davsclaus
Copy link
Contributor

There are CI for 3.14 and 3.11 branches.
Camel 3.15 onwards are JDK11 only.

@davsclaus
Copy link
Contributor

Though the PR may work with JDK8 .. I frankly may be mistaken. We can see when we backport as you will get CI errors then

@zhfeng
Copy link
Contributor Author

zhfeng commented Mar 1, 2022

OK, I will check it with JDK8 locally before backport it to 3.14 and 3.11

@zhfeng zhfeng merged commit 991f9ca into apache:main Mar 1, 2022
zhfeng added a commit to zhfeng/apache-camel that referenced this pull request Mar 1, 2022
apache#7040)

* CAMEL-17474: camel-core - set transacted when copying exchange in multicast processor

* CAMEL-17474: camel-core - similar fix with RecipientList and Split EIP

* CAMEL-17474: add a test for Enrich EIP

* CAMEL-17474 add assertions to check the copied exchanges are marked as transactional
zhfeng added a commit that referenced this pull request Mar 1, 2022
#7040)

* CAMEL-17474: camel-core - set transacted when copying exchange in multicast processor

* CAMEL-17474: camel-core - similar fix with RecipientList and Split EIP

* CAMEL-17474: add a test for Enrich EIP

* CAMEL-17474 add assertions to check the copied exchanges are marked as transactional
@zhfeng
Copy link
Contributor Author

zhfeng commented Mar 1, 2022

@davsclaus It works with JDK 8 and I just backport to 3.14.x

hokutor pushed a commit to hokutor/camel that referenced this pull request Mar 5, 2022
apache#7040)

* CAMEL-17474: camel-core - set transacted when copying exchange in multicast processor

* CAMEL-17474: camel-core - similar fix with RecipientList and Split EIP

* CAMEL-17474: add a test for Enrich EIP

* CAMEL-17474 add assertions to check the copied exchanges are marked as transactional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants