CAMEL-17751: Extracting Camel-Saga-Compensate & Camel-Saga-Complete f… #7118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom CamelHttpQuery header if not present as individual headers
davsclaus
requested changes
Mar 6, 2022
… extraction of query params into a Map
|
The code currently throws a RuntimeCamelException in case the URISupport.parseQuery method throws the URISyntaxException. Is this appropriate? Should it throw something else? |
oscerd
approved these changes
Mar 6, 2022
|
@oscerd should I do it and then open a new PR for main? |
davsclaus
approved these changes
Mar 6, 2022
|
I think we can cherry pick to main so lets try this first |
davsclaus
pushed a commit
that referenced
this pull request
Mar 6, 2022
#7118) * CAMEL-17751: Extracting Camel-Saga-Compensate & Camel-Saga-Complete from CamelHttpQuery header if not present as individual headers * CAMEL-17751: Comments addressing - Usage of URISupport.parseQuery for extraction of query params into a Map Co-authored-by: Vangelis Papanastasatos <papanastasatose@unisystems.gr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the verifyRequest method is not able to retrieve:
Camel-Saga-Compensate&Camel-Saga-Completeas individual headers, try to extract them from the
CamelHttpQueryheader.If found, add them also as headers to the exchange.getIn since if they are not there, neither the compensation or the completion is called correctly.