CAMEL-18019: ensure some fields in the Kafka record fetcher are safe for concurrent read

[orpiske]

No description provided.

[github-actions]

⚠️ This PR changes Camel components and will be tested automatically.

[github-actions]

✔️ Finished component verification: 0 component(s) test failed out of 1 component(s) tested

[essobedo]

What about clientId and lastError? They seem to be shared also

[essobedo]

I see also a potential bug here. Indeed the pollExceptionStrategy is set in the constructor using the value of the field consumer that is always null at this stage

[essobedo]

One more potential issue, the map lastProcessedOffset seems to be read and write by different threads, It looks like it should be a ConcurrentHashMap

[orpiske]

I see also a potential bug here. Indeed the pollExceptionStrategy is set in the constructor using the value of the field consumer that is always null at this stage

Please open a separate ticket for this one.

[orpiske]

I think we should probably abstract the task health state that is exposed to the HealthCheck, so it's easier to know what is being accessed elsewhere.

[essobedo]

I see also a potential bug here. Indeed the pollExceptionStrategy is set in the constructor using the value of the field consumer that is always null at this stage

Please open a separate ticket for this one.

https://issues.apache.org/jira/browse/CAMEL-18020

[orpiske]

One more potential issue, the map lastProcessedOffset seems to be read and write by different threads, It looks like it should be a ConcurrentHashMap

I think we could try to remove this altogether and move its functionality to the commit manager. This is a remainder for the earlier versions of this component (pre 3.7), so I believe what it is trying to do overlaps with what we have there.

[orpiske]

We can also probably remove the reconnect variable at this point (or leave in the appropriate PollExceptionStrategy). Anyway, let's do it in baby steps so it's easier to bisect if we have problems.

[orpiske]

One more potential issue, the map lastProcessedOffset seems to be read and write by different threads, It looks like it should be a ConcurrentHashMap

I logged this one here: https://issues.apache.org/jira/browse/CAMEL-18020 (as explained, I think this one should be reworked and moved to a more appropriate location within the code).

[github-actions]

❌ Finished component verification: 1 component(s) test failed out of 1 component(s) tested

[github-actions]

✔️ Finished component verification: 0 component(s) test failed out of 1 component(s) tested

[orpiske]

I'm going to merge this first bit of changes. Please keep the reviews, comments, tickets going ...