Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMEL-18258 Enhancement to camel splunk component #7981

Merged
merged 1 commit into from Jul 8, 2022
Merged

CAMEL-18258 Enhancement to camel splunk component #7981

merged 1 commit into from Jul 8, 2022

Conversation

claudio4j
Copy link
Contributor

  • Explicit documentation about the token in camel-splunk-hec is not the user's token, but the token generated for the HEC.
  • Add support for token authentication, a safe alternative to the user's password.
  • Escape the error cause when creating the authenticating to splunk (original stacktrace is lost)
  • Document about using the realtime consumer.

https://issues.apache.org/jira/browse/CAMEL-18258

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

⚠️ This PR changes Camel components and will be tested automatically.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

❌ Finished component verification: 1 component(s) test failed out of 2 component(s) tested

@claudio4j
Copy link
Contributor Author

@orpiske can you share the failed build logs ? Thanks.

@orpiske
Copy link
Contributor

orpiske commented Jul 7, 2022

test-logs(2).zip

@orpiske can you share the failed build logs ? Thanks.

Sure thing. I attached it here.

@claudio4j
Copy link
Contributor Author

Thanks Otavio, I fixed the formatting of the code, -Psourcecheck finishes with no failures. Hope it is all good now.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

✔️ Finished component verification: 0 component(s) test failed out of 2 component(s) tested

@orpiske
Copy link
Contributor

orpiske commented Jul 8, 2022

@claudio4j hello, we have just fixed the infra issue preventing the checkstyle from running. Please, would you mind rebasing the code and pushing it again? This should ensure the checks run with the updated code.

Thanks for you contribution!

@claudio4j
Enhancement to camel splunk component
301084b 
* Explicit documentation about the token in camel-splunk-hec is not the user's token, but the token generated for the HEC.
* Add support for token authentication, a safe alternative to the user's password.
* Escape the error cause when creating the authenticating to splunk (original stacktrace is lost)
* Document about using the realtime consumer.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

✔️ Finished component verification: 0 component(s) test failed out of 2 component(s) tested

@orpiske orpiske merged commit 63b3971 into apache:main Jul 8, 2022
@claudio4j claudio4j deleted the fix_splunk branch July 8, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpiske orpiske orpiske approved these changes

Assignees
No one assigned
Labels
components
Projects
None yet
Milestone
No milestone
2 participants
@claudio4j @orpiske