CAMEL-18582: Remove SocketTimeoutException from non retryable classes #8497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Oct 8, 2022
|
🚫 There are (likely) no components to be tested in this PR |
3 similar comments
|
🚫 There are (likely) no components to be tested in this PR |
|
🚫 There are (likely) no components to be tested in this PR |
|
🚫 There are (likely) no components to be tested in this PR |
davsclaus
approved these changes
Oct 8, 2022
|
🚫 There are (likely) no components to be tested in this PR |
3 similar comments
|
🚫 There are (likely) no components to be tested in this PR |
|
🚫 There are (likely) no components to be tested in this PR |
|
🚫 There are (likely) no components to be tested in this PR |
|
During the last build, we can see in the log file that several |
geekrupam
pushed a commit
to geekrupam/camel
that referenced
this pull request
Oct 10, 2022
…apache#8497) ## Motivation With the latest fix, we now get errors of type `SocketTimeoutException: Read timed out` indicating that the runner loses regularly the connection with maven central for some period of time but as it can recover it, to workaround it, we need to make sure that it can retry when it faces this kind of error. ## Modifications: * Use `default` as retry handler instead of `standard` to be able to change the non-retryable classes * By default, `SocketTimeoutException` as a subclass of `InterruptedIOException` is part of the non-retryable classes which is the reason why no retries are made, so we need to redefine the non-retryable classes without `InterruptedIOException` to make sure that it will retry in case of `Read timed out`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://issues.apache.org/jira/browse/CAMEL-18582
Motivation
With the latest fix, we now get errors of type
SocketTimeoutException: Read timed outindicating that the runner loses regularly the connection with maven central for some period of time but as it can recover it, to workaround it, we need to make sure that it can retry when it faces this kind of error.Modifications:
defaultas retry handler instead ofstandardto be able to change the non-retryable classesSocketTimeoutExceptionas a subclass ofInterruptedIOExceptionis part of the non-retryable classes which is the reason why no retries are made, so we need to redefine the non-retryable classes withoutInterruptedIOExceptionto make sure that it will retry in case ofRead timed out