New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAMEL-18646] Provide custom configuration #8661
Conversation
🌟 Thank you for your contribution to the Apache Camel project! 🌟 If necessary Apache Camel Committers may access logs and test results in the job summaries! |
53fc3a4
to
7b9b33b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can also point a remote configfile through resource helper and copy locally in the git repository before using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @gilvansfilho. I've left some comments.
components/camel-git/src/main/java/org/apache/camel/component/RepositoryFactory.java
Outdated
Show resolved
Hide resolved
components/camel-git/src/main/java/org/apache/camel/component/RepositoryFactory.java
Outdated
Show resolved
Hide resolved
Components tested:
|
1 similar comment
Components tested:
|
be75da2
to
bdfb872
Compare
Components tested:
|
Components tested:
|
Components tested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. I think you are on the right track.
I did leave some comments, but I think they are all simple to fix.
components/camel-git/src/main/java/org/apache/camel/component/RepositoryFactory.java
Outdated
Show resolved
Hide resolved
components/camel-git/src/main/java/org/apache/camel/component/RepositoryFactory.java
Outdated
Show resolved
Hide resolved
components/camel-git/src/main/java/org/apache/camel/component/RepositoryFactory.java
Outdated
Show resolved
Hide resolved
components/camel-git/src/main/java/org/apache/camel/component/RepositoryFactory.java
Outdated
Show resolved
Hide resolved
bdfb872
to
e5cae2f
Compare
Components tested:
|
components/camel-git/src/main/java/org/apache/camel/component/git/GitEndpoint.java
Outdated
Show resolved
Hide resolved
Allows user to provide a custom git config file through a endpoint query param
e5cae2f
to
febee1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Components tested:
|
Allows user to provide a custom git config file through a endpoint query param.
Related to Jira issue.