Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAMEL-18646] Provide custom configuration #8661

Merged
merged 1 commit into from Nov 7, 2022

Conversation

gilvansfilho
Copy link
Contributor

Allows user to provide a custom git config file through a endpoint query param.
Related to Jira issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also point a remote configfile through resource helper and copy locally in the git repository before using it.

Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @gilvansfilho. I've left some comments.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

@gilvansfilho gilvansfilho force-pushed the camel-git branch 3 times, most recently from be75da2 to bdfb872 Compare November 5, 2022 21:13
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

Components tested:

Total Tested Failed ❌ Passed ✅
10 10 1 10

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I think you are on the right track.

I did leave some comments, but I think they are all simple to fix.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

Allows user to provide a custom git config file through a endpoint query param
Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

@davsclaus davsclaus merged commit bce2d90 into apache:main Nov 7, 2022
@gilvansfilho gilvansfilho deleted the camel-git branch December 5, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants