Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMEL-18809: RouteDefinitionHelper should resolve the intercepted fro… #8888

Merged
merged 1 commit into from
Dec 13, 2022
Merged

CAMEL-18809: RouteDefinitionHelper should resolve the intercepted fro… #8888

merged 1 commit into from
Dec 13, 2022

Conversation

bvahdat
Copy link
Member

@bvahdat bvahdat commented Dec 13, 2022

…m URI which is configured with property placeholder

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@github-actions github-actions bot added the core label Dec 13, 2022
@github-actions
Copy link
Contributor

🚫 There are (likely) no components to be tested in this PR

orpiske
orpiske approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've left some comments, but they are advisory ones.

...e/camel/builder/RouteTemplateInterceptFromAndInterceptSendToEndpointWithPlaceholderTest.java Outdated Show resolved Hide resolved
...e/camel/builder/RouteTemplateInterceptFromAndInterceptSendToEndpointWithPlaceholderTest.java Show resolved Hide resolved
...e/camel/builder/RouteTemplateInterceptFromAndInterceptSendToEndpointWithPlaceholderTest.java Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚫 There are (likely) no components to be tested in this PR

@bvahdat
CAMEL-18809: RouteDefinitionHelper should resolve the intercepted fro…
b9ca06b 
…m URI which is configured with property placeholder
@github-actions
Copy link
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
2 2 0 3

@nikolag-ikor
Copy link
Contributor

Hello @bvahdat, please check our email conversation from yesterday: https://lists.apache.org/thread/70j2ftwdym70q5yvq6jllo07f3w693f7

I have reported another problem with id placeholders. The problem is described in my emails, and solution for fixing is proposed as well. I expect the fix would be just changing that one line.

Thanks!

@davsclaus davsclaus merged commit 497a339 into main Dec 13, 2022
@davsclaus davsclaus deleted the CAMEL-18809 branch December 13, 2022 16:13
@davsclaus
Copy link
Contributor

@nikolag-ikor can you create a JIRA ticket

@bvahdat
Copy link
Member Author

bvahdat commented Dec 13, 2022

I will look into backporting this PR into the 3.18.x branch

bvahdat added a commit that referenced this pull request Dec 14, 2022
@bvahdat
CAMEL-18809: RouteDefinitionHelper should resolve the intercepted fro…
b76a40b 
…m URI which is configured with property placeholder (#8888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpiske orpiske orpiske approved these changes

@davsclaus davsclaus davsclaus approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
5 participants
@bvahdat @nikolag-ikor @davsclaus @orpiske @oscerd