Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-18932: fixed camel-pulsar tests due to sl4fj upgrade #9157

Merged
merged 1 commit into from Jan 18, 2023

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Jan 18, 2023

This fixes the pulsar errors caused by the upgrade to SL4F 2.

Note: there's a few failures that have been caused by the upgrade to Pulsar 2.11.0 and still need to be fixed.

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@orpiske
Copy link
Contributor Author

orpiske commented Jan 18, 2023

I'll try to fix the errors related to Pulsar upgrade in an separate PR later.

@davsclaus
Copy link
Contributor

is pulsar using directly the old log4j 1.2.x

@orpiske orpiske force-pushed the sl4fj-pulsar-fixes branch 2 times, most recently from cff4e60 to 7d8e508 Compare January 18, 2023 14:49
@orpiske
Copy link
Contributor Author

orpiske commented Jan 18, 2023

is pulsar using directly the old log4j 1.2.x

It depends, directly, on the log4j APIs. From the dep tree:

[INFO] |  +- org.apache.logging.log4j:log4j-api:jar:2.19.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.18.0:compile

@orpiske orpiske marked this pull request as draft January 18, 2023 15:04
@orpiske
Copy link
Contributor Author

orpiske commented Jan 18, 2023

I noticed a problem with this. It works with reload4j, but it's not creating the test log. There's something missing.

@orpiske orpiske marked this pull request as ready for review January 18, 2023 15:26
@orpiske
Copy link
Contributor Author

orpiske commented Jan 18, 2023

is pulsar using directly the old log4j 1.2.x

It depends, directly, on the log4j APIs. From the dep tree:

[INFO] |  +- org.apache.logging.log4j:log4j-api:jar:2.19.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.18.0:compile

It actually has a direct dependency on SLF4j 1.x, not log4j 1.x. Adding org.apache.logging.log4j:log4j-slf4j-impl does the trick.

@github-actions
Copy link
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 1 0

5 similar comments
@github-actions
Copy link
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 1 0

@github-actions
Copy link
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 1 0

@github-actions
Copy link
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 1 0

@github-actions
Copy link
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 1 0

@github-actions
Copy link
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 1 0

@orpiske orpiske merged commit 6f145de into apache:main Jan 18, 2023
@orpiske orpiske deleted the sl4fj-pulsar-fixes branch April 10, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants