CAMEL-19120: Export configurable template #9470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davsclaus
reviewed
Mar 6, 2023
...mel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ExportBaseCommand.java
Outdated
Show resolved
Hide resolved
...amel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ExportSpringBoot.java
Outdated
Show resolved
Hide resolved
...amel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ExportSpringBoot.java
Show resolved
Hide resolved
|
🚫 There are (likely) no components to be tested in this PR |
1 similar comment
|
🚫 There are (likely) no components to be tested in this PR |
oscerd
approved these changes
Mar 6, 2023
|
🚫 There are (likely) no components to be tested in this PR |
davsclaus
reviewed
Mar 6, 2023
| InputStream template = catalog.loadResource("camel-jbang", "spring-boot-pom.tmpl"); | ||
| if (template != null) { | ||
| context = IOHelper.loadText(template); | ||
| IOHelper.close(template); |
There was a problem hiding this comment.
IOHelper automatic close, so no need for this
davsclaus
approved these changes
Mar 6, 2023
davsclaus
approved these changes
Mar 7, 2023
Components tested:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Target
camel-3.x, whereas Camel 4 uses themainbranch)Tracking
Apache Camel coding standards and style
mvn -Pformat,fastinstall install && mvn -Psourcecheck