Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-19270 - camel-netty - add support for unix domain sockets #9869

Merged
merged 1 commit into from Apr 15, 2023

Conversation

iMashtak
Copy link
Contributor

Description

PR brings support for usage of unix domain socket as an alternative to inet socket.

Summary

  • New config property unixDomainSocketPath
  • If property set, host and port becomes unneccessary - similar case to curl --unix-socket option - you need to set host and port but they are ignored
  • Tested using clientMode=true, with no success (i took NettyConsumerClientModeTest as an example) - it just does not work as expected, so i didn't add changes to ClientModeTCPNettyServerBootstrapFactory and mention that case in docs
  • Changed only TCP-related classes, not UDP

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@github-actions
Copy link
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

@davsclaus davsclaus merged commit 873db5f into apache:main Apr 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants