CAMEL-9969: Added a component for Telegram #988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM :-) @davsclaus waiting for your feedback too :-) |
| * The Camel endpoint for a telegram bot. | ||
| */ | ||
| @UriEndpoint(scheme = "telegram", title = "Telegram", syntax = "telegram:type/authorizationToken", consumerClass = TelegramConsumer.class, label = "chat") | ||
| public class TelegramEndpoint extends DefaultEndpoint { |
There was a problem hiding this comment.
The consumer extends ScheduledPollConsumer and therefore you likely want the endpoint to extend ScheduledPollEndpoint that gives you a lot of scheduling outputs for the consumer.
|
Yeah looks very good. I posted some comments on the code. |
|
In the meantime, I fixed the other issues. |
|
Thank look good. @oscerd I think you can merge this to the master branch. |
|
@nicolaferraro @davsclaus Merged! Thanks! :-) |
|
Can you close this PR? Thanks for contribution :-) |
|
Closed. Thank you guys :D |
zregvart
pushed a commit
to zregvart/camel
that referenced
this pull request
Nov 8, 2019
Entesb 11331 sb2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new component for Telegram.
The component uses the Telegram Bot REST API (https://core.telegram.org/bots/api).
There are multiple Java wrappers for the REST API available as open source projects, but
many of them are not "mature" to be included in the camel component.
An alternative option could have been https://github.com/rubenlagus/TelegramBots, but it is
released under GPLv3 license.
Since the Bot API are simple and well documented, I decided to include a Java REST interface directly inside the component.
The Java API that wraps the REST services contains many features (Text messages, audio, video and photo), but it is not 100% complete.
I don't know if it's worth completing it, or maybe leave some issues on Jira to complete it later.
The API is self-consistent at this time, even if it is not complete.
The Telegram services do not allow two bots to exchange messages, so integration tests would be impossible without a human intervention.
So I divided the tests in two stages:
Integration tests are disabled in surefire CI (unless you provide some environment variables).
I added a .adoc file for documenting the endpoint (consumer and producer).
I haven't put the documentation on the Wiki pages because...
I think I had better wait for a review :)