Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-19304: camel-jpa implement paging #9970

Merged
merged 6 commits into from
May 2, 2023

Conversation

jacekszymanski
Copy link
Contributor

Description

Camel JPA endpoint supports option maximumResults, but this is not enough to implement paging. Also, there is no way to specify offset apart from nativeQuery.

maximumResults is static on the endpoint; it may be specified dynamically only using toD, but this means creating dynamic endpoints.

This PR addresses the above:

  • adds support for firstResult
  • both maximumResults and firstResult may be specified in message headers, these override values specified on the endpoint, if any

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@jacekszymanski
Copy link
Contributor Author

Thanks, corrected.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 1 0

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

@davsclaus davsclaus merged commit bbd1140 into apache:main May 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants