-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-19304: camel-jpa implement paging #9970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌟 Thank you for your contribution to the Apache Camel project! 🌟 If necessary Apache Camel Committers may access logs and test results in the job summaries! |
davsclaus
reviewed
May 1, 2023
components/camel-jpa/src/main/java/org/apache/camel/component/jpa/JpaProducer.java
Outdated
Show resolved
Hide resolved
components/camel-jpa/src/main/java/org/apache/camel/component/jpa/JpaProducer.java
Outdated
Show resolved
Hide resolved
Thanks, corrected. |
davsclaus
approved these changes
May 1, 2023
Components tested:
|
oscerd
approved these changes
May 1, 2023
Croway
approved these changes
May 2, 2023
Components tested:
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Camel JPA endpoint supports option maximumResults, but this is not enough to implement paging. Also, there is no way to specify offset apart from nativeQuery.
maximumResults is static on the endpoint; it may be specified dynamically only using toD, but this means creating dynamic endpoints.
This PR addresses the above:
Target
camel-3.x
, whereas Camel 4 uses themain
branch)Tracking
Apache Camel coding standards and style
mvn -Pformat,fastinstall install && mvn -Psourcecheck