CAMEL-19313: resolve option placeholder #9987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 There are (likely) no components to be tested in this PR |
oscerd
approved these changes
May 3, 2023
davsclaus
approved these changes
May 4, 2023
apupier
reviewed
May 9, 2023
| return doCall(); | ||
| } | ||
|
|
||
| private void replacePlaceholders() throws Exception { | ||
| for (CommandLine.Model.ArgSpec argSpec : spec.args()) { | ||
| String defaultValue = spec.defaultValueProvider().defaultValue(argSpec); |
There was a problem hiding this comment.
the default values are the values set in configuration? (like when set with jbang camel@apache/camel config set repos=https://maven.repository.redhat.com/ga)
There was a problem hiding this comment.
exactly, the defaultValueProvider() loads the value from the properties file (updated via camel config set)
|
Can you maybe also add a little part in the camel-jbang doc about this |
apupier
approved these changes
May 11, 2023
There was a problem hiding this comment.
- tested locally manually with Camel Main
- the notation used for the placeholder is $name, so for instance --repos=$repos,https://another.repo
- agree that it would be nice to mention it in the documentation but I guess it can also be done in another Pull request
- I linked the issue https://issues.apache.org/jira/browse/CAMEL-19313 to the issue about writing the integration tests for Camel JBang https://issues.apache.org/jira/browse/CAMEL-19338
- @Croway launched the current integration tests of this branch and no regression were detected
|
Thanks @apupier for checking it, I have added some doc too. |
|
🚫 There are (likely) no components to be tested in this PR |
apupier
approved these changes
May 15, 2023
|
This is a draft PR is it ready to be merged or do you need more work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Target
camel-3.x, whereas Camel 4 uses themainbranch)Tracking
Apache Camel coding standards and style
mvn -Pformat,fastinstall install && mvn -Psourcecheck