-
Notifications
You must be signed in to change notification settings - Fork 704
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CARBONDATA-2447] Block update operation on range/list/hash partition…
… table [problem] when update the data on range partition table, it will lost data or update failed , see the jira or new test case [Cause] Range partition table take taskNo in filename as partitionId, when update the taskNo is inscreasing ,the taskNo didn't changed with partitionId [Solution] (1) When query the range partition table, don't match the partitionid ---this method losses the meaning of partition (2) Range partition table use directory or seperate part as partitionid ---this is not necessary and suggest to use standard partition (3) Range partition table doesn't support update opretion ---this PR use this method This closes #3091
- Loading branch information
1 parent
9672a10
commit 1470f78
Showing
2 changed files
with
79 additions
and
1 deletion.
There are no files selected for viewing
71 changes: 71 additions & 0 deletions
71
...t/scala/org/apache/carbondata/spark/testsuite/partition/TestUpdateForPartitionTable.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.carbondata.spark.testsuite.partition | ||
|
||
import org.apache.spark.sql.test.util.QueryTest | ||
import org.scalatest. BeforeAndAfterAll | ||
|
||
class TestUpdateForPartitionTable extends QueryTest with BeforeAndAfterAll { | ||
|
||
override def beforeAll: Unit = { | ||
dropTable | ||
|
||
sql("create table test_range_partition_table (id int) partitioned by (name string) " + | ||
"stored by 'carbondata' TBLPROPERTIES('PARTITION_TYPE' = 'RANGE','RANGE_INFO' = 'a,e,f')") | ||
sql("create table test_hive_partition_table (id int) partitioned by (name string) " + | ||
"stored by 'carbondata'") | ||
sql("create table test_hash_partition_table (id int) partitioned by (name string) " + | ||
"stored by 'carbondata' TBLPROPERTIES('PARTITION_TYPE' = 'HASH','NUM_PARTITIONS' = '2')") | ||
sql("create table test_list_partition_table (id int) partitioned by (name string) " + | ||
"stored by 'carbondata' TBLPROPERTIES('PARTITION_TYPE' = 'LIST','LIST_INFO' = 'a,e,f')") | ||
} | ||
|
||
def dropTable = { | ||
sql("drop table if exists test_hash_partition_table") | ||
sql("drop table if exists test_list_partition_table") | ||
sql("drop table if exists test_range_partition_table") | ||
sql("drop table if exists test_hive_partition_table") | ||
} | ||
|
||
|
||
test ("test update for unsupported partition table") { | ||
val updateTables = Array( | ||
"test_range_partition_table", | ||
"test_list_partition_table", | ||
"test_hash_partition_table") | ||
|
||
updateTables.foreach(table => { | ||
sql("insert into " + table + " select 1,'b' ") | ||
val ex = intercept[UnsupportedOperationException] { | ||
sql("update " + table + " set (name) = ('c') where id = 1").collect() | ||
} | ||
assertResult("Unsupported update operation for range/hash/list partition table")(ex.getMessage) | ||
}) | ||
|
||
} | ||
|
||
test ("test update for hive(standard) partition table") { | ||
|
||
sql("insert into test_hive_partition_table select 1,'b' ") | ||
sql("update test_hive_partition_table set (name) = ('c') where id = 1").collect() | ||
assertResult(1)(sql("select * from test_hive_partition_table where name = 'c'").collect().length) | ||
} | ||
|
||
override def afterAll() : Unit = { | ||
dropTable | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters