Skip to content

Commit

Permalink
[CARBONDATA-3302] [Spark-Integration] code cleaning related to Carbon…
Browse files Browse the repository at this point in the history
…CreateTable command

What changes were proposed in this pull request?
Removed Extra check to validate whether the stream relation is not null , moreover condition can be optimized further,
currently the condition has path validation whether path is part of s3 file system and then system is checking
whether the stream relation is not null, this check can be added initially as this overall
condition has to be evaluated for stream table only if stream is not null.

This closes #3134
  • Loading branch information
sujith71955 authored and kumarvishal09 committed Mar 20, 2019
1 parent dda3e7d commit 66982f3
Showing 1 changed file with 1 addition and 2 deletions.
Expand Up @@ -78,8 +78,7 @@ case class CarbonCreateTableCommand(
path
}
val streaming = tableInfo.getFactTable.getTableProperties.get("streaming")
if (path.startsWith("s3") && streaming != null && streaming != null &&
streaming.equalsIgnoreCase("true")) {
if (streaming != null && streaming.equalsIgnoreCase("true") && path.startsWith("s3")) {
throw new UnsupportedOperationException("streaming is not supported with s3 store")
}
tableInfo.setTablePath(tablePath)
Expand Down

0 comments on commit 66982f3

Please sign in to comment.