fix findbugs

apache · Sep 12, 2017 · b711419 · b711419
1 parent 9f425e5
commit b711419
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java b/processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java
@@ -278,7 +278,7 @@ public void fillCardinalityAfterDataLoad(List<Integer> dimCardWithComplex,
   }
 
   @Override
-  public GenericDataType clone() {
-    return new ArrayDataType(this.outputArrayIndex, this.dataCounter, this.children.clone());
+  public GenericDataType<ArrayObject> deepCopy() {
+    return new ArrayDataType(this.outputArrayIndex, this.dataCounter, this.children.deepCopy());
   }
 }
diff --git a/processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java b/processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java
@@ -145,5 +145,5 @@ void parseAndBitPack(ByteBuffer byteArrayInput, DataOutputStream dataOutputStrea
   /**
    * clone self for multithread access (for complex type processing in table page)
    */
-  GenericDataType<T> clone();
+  GenericDataType<T> deepCopy();
 }
diff --git a/processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java b/processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java
@@ -325,7 +325,7 @@ public void fillCardinalityAfterDataLoad(List<Integer> dimCardWithComplex,
   }
 
   @Override
-  public GenericDataType clone() {
+  public GenericDataType<Object> deepCopy() {
     PrimitiveDataType dataType = new PrimitiveDataType(this.outputArrayIndex, 0);
     dataType.setKeySize(this.keySize);
     dataType.setSurrogateIndex(this.index);

diff --git a/processing/src/main/java/org/apache/carbondata/processing/datatypes/StructDataType.java b/processing/src/main/java/org/apache/carbondata/processing/datatypes/StructDataType.java
@@ -304,10 +304,10 @@ public void fillCardinalityAfterDataLoad(List<Integer> dimCardWithComplex,
   }
 
   @Override
-  public GenericDataType clone() {
+  public GenericDataType<StructObject> deepCopy() {
     List<GenericDataType> childrenClone = new ArrayList<>();
     for (GenericDataType child : children) {
-      childrenClone.add(child.clone());
+      childrenClone.add(child.deepCopy());
     }
     return new StructDataType(childrenClone, this.outputArrayIndex, this.dataCounter);
   }