-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CARBONDATA-1150]updated configuration-parameters.md for vector reader support #1014
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the parameter is enabled by default we need not specify again in description.
We can change the description to below:
This parameter increases the query performance.
@sgururajshetty please review i have updated the description |
Refer to this link for build results (access rights to CI server needed): |
docs/configuration-parameters.md
Outdated
@@ -58,7 +58,7 @@ This section provides the details of all the configurations required for CarbonD | |||
| carbon.merge.sort.prefetch | true | Enable prefetch of data during merge sort while reading data from sort temp files in data loading. | | | |||
| carbon.update.persist.enable | true | Enabling this parameter considers persistent data. Enabling this will reduce the execution time of UPDATE operation. | | | |||
| carbon.load.global.sort.partitions | 0 | The Number of partitions to use when shuffling data for sort. If user don't configurate or configurate it less than 1, it uses the number of map tasks as reduce tasks. In general, we recommend 2-3 tasks per CPU core in your cluster. | |||
|
|||
| carbon.enable.vector.reader | true | This parameter increases the query performance. | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to give more information about this option, perhaps you can describe why it can increase performance and give hint when to enable this feature
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/749/ |
No description provided.