Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-1150]updated configuration-parameters.md for vector reader support #1014

Closed
wants to merge 1 commit into from

Conversation

vandana7
Copy link
Contributor

@vandana7 vandana7 commented Jun 9, 2017

No description provided.

@asfgit
Copy link

asfgit commented Jun 9, 2017

Can one of the admins verify this patch?

1 similar comment
@CarbonDataQA
Copy link

Can one of the admins verify this patch?

@asfgit
Copy link

asfgit commented Jun 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/198/

@asfgit
Copy link

asfgit commented Jun 14, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/343/

Copy link
Contributor

@sgururajshetty sgururajshetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the parameter is enabled by default we need not specify again in description.

We can change the description to below:

This parameter increases the query performance.

@vandana7
Copy link
Contributor Author

@sgururajshetty please review i have updated the description

@asfgit
Copy link

asfgit commented Jun 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/429/

@@ -58,7 +58,7 @@ This section provides the details of all the configurations required for CarbonD
| carbon.merge.sort.prefetch | true | Enable prefetch of data during merge sort while reading data from sort temp files in data loading. | |
| carbon.update.persist.enable | true | Enabling this parameter considers persistent data. Enabling this will reduce the execution time of UPDATE operation. | |
| carbon.load.global.sort.partitions | 0 | The Number of partitions to use when shuffling data for sort. If user don't configurate or configurate it less than 1, it uses the number of map tasks as reduce tasks. In general, we recommend 2-3 tasks per CPU core in your cluster.

| carbon.enable.vector.reader | true | This parameter increases the query performance. | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to give more information about this option, perhaps you can describe why it can increase performance and give hint when to enable this feature

@CarbonDataQA
Copy link

Can one of the admins verify this patch?

1 similar comment
@CarbonDataQA
Copy link

Can one of the admins verify this patch?

@ravipesala
Copy link
Contributor

Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/749/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants