[CARBONDATA-1312] fix list partition compare issue #1183
Conversation
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3111/ |
|
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/520/ |
| @@ -63,6 +64,9 @@ public static BitSet getPartitionMapForRangeFilter(PartitionInfo partitionInfo, | |||
| for (String value : values.get(i)) { | |||
| Object listValue = PartitionUtil.getDataBasedOnDataType(value, partitionColumnDataType, | |||
| timestampFormatter, dateFormatter); | |||
| if (listValue instanceof String) { | |||
| listValue = ByteUtil.toBytes((String)listValue); | |||
| } | |||
There was a problem hiding this comment.
please improve performance and refractory code.
we should convert value only once. please move the code to the outside of for loop.
There was a problem hiding this comment.
cannot move to outside here.
| sql("select empno, empname, designation, doj, workgroupcategory, workgroupcategoryname, deptno, deptname, projectcode, projectjoindate, projectenddate, attendance, utilization, salary from originTable where empno in (11, 13)")) | ||
| } | ||
|
|
||
| test("detail query on partition table: range partition") { |
There was a problem hiding this comment.
please add test case for list and range partition:
create table:
- partition column is string, and add partition column to dictionary_exclude (means )
- partition column is string
query:
filter on partition column , support <. <=, >, >= operate.
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3120/ |
|
Build Failed with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/529/ |
|
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/542/ |
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3134/ |
|
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/544/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3136/ |
|
LGTM |
1 similar comment
|
LGTM |
need to convert string to bytes in list partition comparator