[CARBONDATA-1310]Merge test code for AddColumnTestCases, DropColumnTestCases and ChangeDataTypeTestCases #1186
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3118/ |
|
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/527/ |
| } | ||
|
|
||
| test("test like query on new column") { | ||
| sqlContext.setConf("carbon.enable.vector.reader", "true") |
There was a problem hiding this comment.
Why need to add the vector settings?
There was a problem hiding this comment.
true should means vector reader, false means row reader, actually it is the main difference between the 2 test class packages which need to merge
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3128/ |
|
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/537/ |
mayunSaicmotor
changed the title
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3167/ |
|
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/572/ |
| } | ||
|
|
||
| test("test add dictionary column and test greaterthan/lessthan filter on new column") ({ |
brackets, and drop all used tables in afterAll method
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3171/ |
|
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/577/ |
|
LGTM |
merge test code for AddColumnTestCases, DropColumnTestCases and ChangeDataTypeTestCases
between packages,