New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CARBONDATA-1205] Use Spark 2.1 as default compilation in parent pom #1226
Conversation
From 1.2.0, there are many features developing based on Spark 2.1, so use Spark2.1 as default compilation in parent pom.
Can one of the admins verify this patch? |
@@ -401,6 +398,9 @@ | |||
</profile> | |||
<profile> | |||
<id>spark-2.1</id> | |||
<activation> | |||
<activeByDefault>true</activeByDefault> | |||
</activation> | |||
<properties> | |||
<spark.version>2.1.0</spark.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use spark 2.1.1 as default version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let us first focus on 2.1.0. we can support 2.1.1 or 2.2 later as per most of users' requirements.
SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/78/ |
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3335/ |
retest this please |
apache2.1 retest this please |
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3344/ |
SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/86/ |
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/746/ |
@chenliang613 even spark-common-test/pom.xml also has |
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3350/ |
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/752/ |
SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/90/ |
LGTM |
From 1.2.0, there are many features developing based on Spark 2.1, so use Spark2.1 as default compilation in parent pom. This closes apache#1226
From 1.2.0, there are many features developing based on Spark 2.1, so use Spark2.1 as default compilation in parent pom.