Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-1205] Use Spark 2.1 as default compilation in parent pom #1226

Closed
wants to merge 3 commits into from
Closed

[CARBONDATA-1205] Use Spark 2.1 as default compilation in parent pom #1226

wants to merge 3 commits into from

Conversation

chenliang613
Copy link
Contributor

From 1.2.0, there are many features developing based on Spark 2.1, so use Spark2.1 as default compilation in parent pom.

From 1.2.0, there are many features developing based on Spark 2.1, so use Spark2.1 as default compilation in parent pom.
@asfgit
Copy link

asfgit commented Aug 3, 2017

Can one of the admins verify this patch?

@chenliang613 chenliang613 changed the title [CARBONDATA-1205] Use Spark 2.1 as default from 1.2.0 onwards [CARBONDATA-1205] Use Spark 2.1 as default compilation in parent pom. Aug 3, 2017
@chenliang613 chenliang613 changed the title [CARBONDATA-1205] Use Spark 2.1 as default compilation in parent pom. [CARBONDATA-1205] Use Spark 2.1 as default compilation in parent pom Aug 3, 2017
@@ -401,6 +398,9 @@
</profile>
<profile>
<id>spark-2.1</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<properties>
<spark.version>2.1.0</spark.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use spark 2.1.1 as default version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us first focus on 2.1.0. we can support 2.1.1 or 2.2 later as per most of users' requirements.

@CarbonDataQA
Copy link

SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/78/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3335/

@chenliang613
Copy link
Contributor Author

retest this please

@chenliang613
Copy link
Contributor Author

apache2.1 retest this please

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3344/

@ravipesala
Copy link
Contributor

SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/86/

@ravipesala
Copy link
Contributor

Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/746/

@ravipesala
Copy link
Contributor

@chenliang613 even spark-common-test/pom.xml also has <skipTests>false</skipTests> , please remove it

@ravipesala
Copy link
Contributor

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3350/

@ravipesala
Copy link
Contributor

Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/752/

@ravipesala
Copy link
Contributor

SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/90/

@ravipesala
Copy link
Contributor

LGTM

@asfgit asfgit closed this in 7248d0e Aug 4, 2017
anubhav100 pushed a commit to anubhav100/incubator-carbondata that referenced this pull request Aug 9, 2017
From 1.2.0, there are many features developing based on Spark 2.1, so use Spark2.1 as default compilation in parent pom.

This closes apache#1226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants