Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-649] fix for update with rand function #1296

Closed
wants to merge 1 commit into from
Closed

[CARBONDATA-649] fix for update with rand function #1296

wants to merge 1 commit into from

Conversation

ashwini-krishnakumar
Copy link
Contributor

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [CARBONDATA-<Jira issue #>] Description of pull request

  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).

  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.

  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

  • Testing done

     Please provide details on 
 - Whether new unit test cases have been added or why no new tests are required?
 - What manual testing you have done?
 - Any additional information to help reviewers in testing this change.

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@CarbonDataQA
Copy link

Can one of the admins verify this patch?

1 similar comment
@CarbonDataQA
Copy link

Can one of the admins verify this patch?

@ravipesala
Copy link
Contributor

retest this please

ravipesala
ravipesala reviewed Aug 31, 2017
View reviewed changes
integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonLateDecodeRule.scala
@@ -841,3 +868,45 @@ case class CarbonDecoderRelation(

lazy val dictionaryMap = carbonRelation.carbonRelation.metaData.dictionaryMap
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this class dummy class out of this class

@ashwini-krishnakumar
Copy link
Contributor Author

retest this please

@CarbonDataQA
Copy link

SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/364/

@ashwini-krishnakumar
Copy link
Contributor Author

@ravipesala please review

@ravipesala
Copy link
Contributor

LGTM

@ravipesala
Copy link
Contributor

@ashwini-krishnakumar Please amend all comments as single comment. There is an issue while merging to master.

@ravipesala
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@CarbonDataQA
Copy link

Can one of the admins verify this patch?

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/596/

ravipesala
ravipesala reviewed Sep 9, 2017
View reviewed changes
...est/src/test/scala/org/apache/carbondata/spark/testsuite/iud/UpdateCarbonTableTestCase.scala Outdated
| BIGINT_COLUMN2,DECIMAL_COLUMN1,DECIMAL_COLUMN2,Double_COLUMN1,Double_COLUMN2,INTEGER_COLUMN1')"""
.stripMargin).collect()

sql(s"""LOAD DATA INPATH '$resourcesPath/IUD/2000_UniqData.csv' into table rand OPTIONS('DELIMITER'=',' , 'QUOTECHAR'='"','BAD_RECORDS_ACTION'='FORCE','FILEHEADER'='CUST_ID,CUST_NAME,ACTIVE_EMUI_VERSION,DOB,DOJ,BIGINT_COLUMN1,BIGINT_COLUMN2,DECIMAL_COLUMN1,DECIMAL_COLUMN2,Double_COLUMN1,Double_COLUMN2,INTEGER_COLUMN1')""").collect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to use the csv files which are already existed for this testcase. I don't see any reason to add new csv for this simple testcase.

@ashwini-krishnakumar
CARBONDATA-649 fix for update with rand()
dac71d9 
updated testcase to reuse the existing data file
@ashwini-krishnakumar
Copy link
Contributor Author

Updated UpdateCarbonTableTestCase.scala to use an existing csv file

@ravipesala
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@CarbonDataQA
Copy link

Can one of the admins verify this patch?

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/653/

@ravipesala
Copy link
Contributor

LGTM

@asfgit asfgit closed this in 8b38e0b Sep 11, 2017
xubo245 pushed a commit to xubo245/carbondata that referenced this pull request Sep 17, 2017
@ashwini-krishnakumar @xubo245
[CARBONDATA-649] fix for update with rand function
fb56f86 
This closes apache#1296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravipesala ravipesala ravipesala left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashwini-krishnakumar @CarbonDataQA @ravipesala