[WIP] Min Max DataMap Example #1329
Conversation
|
Great, thanks for working on this! |
| @@ -61,6 +61,9 @@ | |||
| public static final CacheType<TableSegmentUniqueIdentifier, SegmentTaskIndexWrapper> | |||
| DRIVER_BLOCKLET_DATAMAP = new CacheType("driver_blocklet_datamap"); | |||
|
|
|||
| public static final CacheType<TableSegmentUniqueIdentifier, SegmentTaskIndexWrapper> | |||
There was a problem hiding this comment.
Don't add cache type, no need to handle cache in example
| /** | ||
| * Datamap implementation for blocklet. | ||
| */ | ||
| public class DataMapMinMax implements DataMap, Cacheable { |
There was a problem hiding this comment.
No need to use Unsafe in example, don't confuse users with unsafe in example. just make it as simple as possibe
| import org.apache.carbondata.core.util.CarbonProperties | ||
|
|
||
|
|
||
| class DataMapMinMaxWriter extends QueryTest with BeforeAndAfterAll { |
There was a problem hiding this comment.
Append testcase to the file name
|
|
||
| } | ||
|
|
||
| public void updateMinMaxIndex(String filePath) throws IOException, MemoryException { |
There was a problem hiding this comment.
it shouldn't be read from index file. Use the Datamap writer to write example index file and read here
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/9/ |
Min Max DataMap Example