Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-1531] Format module should support BOOLEAN #1392

Closed
wants to merge 1 commit into from

Conversation

xubo245
Copy link
Contributor

@xubo245 xubo245 commented Sep 28, 2017

format module support Boolean data type when I was developing Boolean function, and there are some error in CI after push request into github. So format module should support Boolean.

  1. add Boolean data type
  2. add BOOL_BYTE in Encoding

@xubo245
Copy link
Contributor Author

xubo245 commented Sep 28, 2017

Please review and merge it. @jackylk

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/310/

@CarbonDataQA
Copy link

Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/185/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/941/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/315/

@CarbonDataQA
Copy link

Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/190/

@@ -52,7 +53,8 @@ enum Encoding{
ADAPTIVE_DELTA_INTEGRAL = 8; // Identifies that a column is encoded using AdaptiveDeltaIntegralCodec
RLE_INTEGRAL = 9; // Identifies that a column is encoded using RLECodec
DIRECT_STRING = 10; // Stores string value and string length separately in page data
ADAPTIVE_FLOATING = 11; // Identifies that a column is encoded using AdaptiveFloatingCodec
ADAPTIVE_FLOATING = 11; // Identifies that a column is encoded using AdaptiveFloatingCodec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct the indentation

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/947/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/323/

@CarbonDataQA
Copy link

Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/199/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/951/

@xubo245
Copy link
Contributor Author

xubo245 commented Sep 28, 2017

I have changed indentation @jackylk

@asfgit asfgit closed this in b221c98 Sep 28, 2017
@jackylk
Copy link
Contributor

jackylk commented Sep 28, 2017

LGTM

anubhav100 pushed a commit to anubhav100/incubator-carbondata that referenced this pull request Jun 22, 2018
format module support Boolean data type when I was developing Boolean function, and there are some error in CI after push request into github. So format module should support Boolean.

add Boolean data type
add BOOL_BYTE in Encoding

This closes apache#1392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants