-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CARBONDATA-1531] Format module should support BOOLEAN #1392
Conversation
Please review and merge it. @jackylk |
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/310/ |
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/185/ |
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/941/ |
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/315/ |
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/190/ |
format/src/main/thrift/schema.thrift
Outdated
@@ -52,7 +53,8 @@ enum Encoding{ | |||
ADAPTIVE_DELTA_INTEGRAL = 8; // Identifies that a column is encoded using AdaptiveDeltaIntegralCodec | |||
RLE_INTEGRAL = 9; // Identifies that a column is encoded using RLECodec | |||
DIRECT_STRING = 10; // Stores string value and string length separately in page data | |||
ADAPTIVE_FLOATING = 11; // Identifies that a column is encoded using AdaptiveFloatingCodec | |||
ADAPTIVE_FLOATING = 11; // Identifies that a column is encoded using AdaptiveFloatingCodec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct the indentation
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/947/ |
98c5b90
to
76bede2
Compare
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/323/ |
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/199/ |
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/951/ |
I have changed indentation @jackylk |
LGTM |
format module support Boolean data type when I was developing Boolean function, and there are some error in CI after push request into github. So format module should support Boolean. add Boolean data type add BOOL_BYTE in Encoding This closes apache#1392
format module support Boolean data type when I was developing Boolean function, and there are some error in CI after push request into github. So format module should support Boolean.