[WIP] [CARBONDATA-1592] Adding event listener interface to Carbondata #1416
Conversation
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/462/ |
|
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/337/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1090/ |
manishgupta88
changed the title
manishgupta88
force-pushed
the
event_listener_module
branch
from
2e5f3d1
to
37ca41c
Compare
|
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/340/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/465/ |
| dataMapFactory.fireEvent(event); | ||
| } | ||
|
|
||
| @Override public void onAbort(Event event) { |
There was a problem hiding this comment.
this method is not required in Event Interface as Abort is a separate event.
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1093/ |
manishgupta88
force-pushed
the
event_listener_module
branch
from
37ca41c
to
c10f1ae
Compare
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/468/ |
|
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/343/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1096/ |
manishgupta88
force-pushed
the
event_listener_module
branch
from
c10f1ae
to
894ed44
Compare
|
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/350/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/475/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1103/ |
manishgupta88
force-pushed
the
event_listener_module
branch
from
894ed44
to
105e603
Compare
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/476/ |
|
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/351/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1104/ |
manishgupta88
force-pushed
the
event_listener_module
branch
from
105e603
to
3d41463
Compare
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/478/ |
|
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/353/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1106/ |
| /** | ||
| * event for load operations | ||
| */ | ||
| trait LoadEvent extends TableEvent { |
There was a problem hiding this comment.
Move this trait to LoadEvents class
There was a problem hiding this comment.
I think it is better to keep all the possible events in Events.scala class in order to know what all different type of events are possible and keep their concrete implementation in different classes to clearly define their behavior.
| .config("spark.driver.host", "localhost") | ||
| .getOrCreateCarbonSession(storeLocation) | ||
| val carbonTableIdentifier = new CarbonTableIdentifier("db1", "tbl1", "tbl1-id") | ||
| val carbonLoadModel = new CarbonLoadModel |
There was a problem hiding this comment.
Example to be used how to subscribe to data load event
|
Can you explain more on the intention of this PR? |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1175/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/544/ |
manishgupta88
force-pushed
the
event_listener_module
branch
from
3d41463
to
f1e26fc
Compare
|
@jackylk ..This PR will provide an event listener interface using which you can register the events based on the need of your operations. For example before dropping a table you need to record the information from that table that can be used for clean up of resources/caches used by that table on executor or driver side. In this case you can register an event PreDropEventListener which will perform the required task and add an event which will triggered just before drop. |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1284/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/650/ |
rahulk2
force-pushed
the
event_listener_module
branch
from
f1e26fc
to
e9891d6
Compare
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/854/ |
|
Code already merged as part of PR #1473 |
Adding event listener interface to Carbondata