Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-1656][Streaming] Reject alter table command for streaming table #1448

Closed
wants to merge 2 commits into from
Closed

[CARBONDATA-1656][Streaming] Reject alter table command for streaming table #1448

wants to merge 2 commits into from

Conversation

jackylk
Copy link
Contributor

@jackylk jackylk commented Oct 29, 2017

ALTER TABLE command should be rejected as streaming table does not support it.
Exception should be thrown in this scenario

  • Any interfaces changed?
    No

  • Any backward compatibility impacted?
    No

  • Document update required?
    Yes

  • Testing done
    Testcase is added

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

@jackylk jackylk changed the title [CARBONDATA-1656] Reject alter table command for streaming table [CARBONDATA-1656][Streaming] Reject alter table command for streaming table Oct 29, 2017
@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/731/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1368/

@jackylk jackylk changed the base branch from master to streaming_ingest October 30, 2017 09:30
@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/743/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1380/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/798/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1430/

@jackylk jackylk changed the base branch from streaming_ingest to master November 6, 2017 02:06
@jackylk
Copy link
Contributor Author

jackylk commented Nov 6, 2017

retest this please

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/814/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/816/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1448/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/843/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1476/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/845/

@jackylk
Copy link
Contributor Author

jackylk commented Nov 7, 2017

retest this please

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/847/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1478/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1480/

@jackylk jackylk force-pushed the block_alter_table branch 2 times, most recently from e4bc5fc to 91bf894 Compare November 8, 2017 02:53
@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/855/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/857/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/864/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/868/

@asfgit asfgit closed this in 8789252 Nov 8, 2017
@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1487/

@jackylk jackylk mentioned this pull request Nov 12, 2017
Closed
5 tasks
jatin9896 pushed a commit to jatin9896/incubator-carbondata that referenced this pull request Jan 5, 2018
@jackylk @jatin9896
[CARBONDATA-1656][Streaming] Reject alter table command for streaming…
149e997 
… table

This closes apache#1448
anubhav100 pushed a commit to anubhav100/incubator-carbondata that referenced this pull request Jun 22, 2018
@jackylk @anubhav100
[CARBONDATA-1656][Streaming] Reject alter table command for streaming…
67ffdc3 
… table

This closes apache#1448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackylk @CarbonDataQA @ravipesala