[Docs] Fix partition-guide.md docs NUM_PARTITIONS wrong keyword #1460
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
add to whitelist |
|
@LiShuMing can you explain why? :) |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/803/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1436/ |
|
@chenliang613 According https://github.com/apache/carbondata/blob/master/integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala#171 says, I think it's a spelling mistake? |
docs/partition-guide.md
Outdated
| @@ -39,7 +39,7 @@ This tutorial is designed to provide a quick introduction to create and use part | |||
| PARTITIONED BY (partition_col_name data_type) | |||
| STORED BY 'carbondata' | |||
| [TBLPROPERTIES ('PARTITION_TYPE'='HASH', | |||
| 'PARTITION_NUM'='N' ...)] | |||
| 'NUM_PARTITION'='N' ...)] | |||
There was a problem hiding this comment.
It should be NUM_PARTITIONS
|
@LiShuMing Likun comment is right, should be : "NUM_PARTITIONS" , please update it . |
|
@chenliang613 already done. |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1299/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1768/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1769/ |
|
Can one of the admins verify this patch? |
|
please rebase to branch master |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1408/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1853/ |
|
@LiShuMing please rebase |
|
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/958/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3060/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4304/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3237/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5192/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3982/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7130/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5906/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/57/ |
|
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8806/ |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/739/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/561/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2009/ |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2186/ |
|
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10261/ |
|
Build Failed with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/84/ |
|
Build Failed with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/83/ |
|
Sorry. I find this's document is unused. I just close it. |
It's an obvious keyword spelling mistake,
PARTITION_NUMshould beNUM_PARTITION.No Tests.