[CARBONDATA-1717]Remove spark broadcast for gettting hadoop configurations #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashrn5
changed the title
|
@QiangCai please review |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1147/ |
|
@ravipesala @jackylk please review |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1149/ |
|
retest this please |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1150/ |
|
please fix CI issue |
|
retest this please |
|
retest sdv pleaase |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1173/ |
|
LGTM |
jatin9896
pushed a commit
to jatin9896/incubator-carbondata
that referenced
this pull request
Jan 5, 2018
anubhav100
pushed a commit
to anubhav100/incubator-carbondata
that referenced
this pull request
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why?
with the new conf set in hadoop conf, after broadcast conf will not get reflected, hence these changes
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
[*] Any interfaces changed?
NONE
[*] Any backward compatibility impacted?
NONE
[*] Document update required?
NONE
[*] Testing done
test cases are not required, SDV will take care
[*] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NONE