[CARBONDATA-1592] Added event listeners #1562
Conversation
|
retest this please |
|
retest sdv please |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1857/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1432/ |
|
@ManoharVanam please rebase |
ManoharVanam
force-pushed
the
Listeners
branch
from
6892b33
to
d5fac55
Compare
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1496/ |
| carbonLoadModel, | ||
| factPath, | ||
| dataFrame.isDefined, | ||
| optionsFinal) |
There was a problem hiding this comment.
carbonloadmodel is already getting passed... it there any other property that is getting used from optionsFinal variable?
There was a problem hiding this comment.
yeah , Iam getting bad records info from optionsFinal for validation purpose in pre event listener.
after validating we are setting to carbonLoadModel, so this is required
|
Apart from 1 comment given, LGTM |
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1505/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1913/ |
ManoharVanam
force-pushed
the
Listeners
branch
from
d5fac55
to
d31f93a
Compare
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1538/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1939/ |
|
LGTM |
Description : Added Event Listener interface to Carbondata. This will allow extending the current functionality of various commands to perform various other operations. This closes apache#1562
Description : Added Event Listener interface to Carbondata. This will allow extending the current functionality of various commands to perform various other operations. This closes apache#1562
Description : Added Event Listener interface to Carbondata. This will allow extending the current functionality of various commands to perform various other operations.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.