[CARBONDATA-1789][CARBONDATA-1791]do not drop the table if the load, insert or insert overwrite is in progress #1610
Conversation
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/416/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2074/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1688/ |
akashrn5
force-pushed
the
drop
branch
3 times, most recently
from
aa8e1f9
to
d1ba17d
Compare
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/424/ |
akashrn5
changed the title
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2083/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/425/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1696/ |
| * This function checks if any load or insert overwrite is in progress before dropping that table | ||
| * @return | ||
| */ | ||
| def checkLoadInProgressForTable(carbonTable: CarbonTable): Boolean = { |
There was a problem hiding this comment.
Please move this method to SegmentStatusManager
| * This function checks if any load or insert overwrite is in progress before dropping that table | ||
| * @return | ||
| */ | ||
| def checkLoadInProgressForTable(carbonTable: CarbonTable): Boolean = { |
There was a problem hiding this comment.
Please change name of method to checkIfAnyLoadInProgressForTable
| * @return | ||
| */ | ||
| def checkLoadInProgressForTable(carbonTable: CarbonTable): Boolean = { | ||
| var canDropTable = true |
There was a problem hiding this comment.
Rename the variable name to loadInProgress and initialize to false
|
@akashrn5 Please try to add testcase. |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2087/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/433/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1703/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/434/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2088/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1704/ |
|
retest this please |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/438/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1708/ |
akashrn5
changed the title
akashrn5
force-pushed
the
drop
branch
3 times, most recently
from
85fee1d
to
3b0da21
Compare
|
@ravipesala i have added test case for both scenario |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/488/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1752/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2135/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/506/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1767/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1773/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2148/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/532/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/536/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1790/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2163/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2168/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/547/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1804/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/568/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2178/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1816/ |
|
LGTM |
…insert or insert overwrite is in progress This closes apache#1610
…insert or insert overwrite is in progress This closes apache#1610
do not drop the table if the load, insert or insert overwrite is in progress
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
NA
NA
NA
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
local testing is done