Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-1870] Add dictionary path support to carbondata #1617

Closed
wants to merge 1 commit into from
Closed

[CARBONDATA-1870] Add dictionary path support to carbondata #1617

wants to merge 1 commit into from

Conversation

manishgupta88
Copy link
Contributor

@manishgupta88 manishgupta88 commented Dec 5, 2017 •
edited

Added dictionary path support. Carbondata dictionary framework is further enhanced to support reading dictionary files from a given dictionary file location.

  • Any interfaces changed?
    No

  • Any backward compatibility impacted?
    No

  • Document update required?
    No

  • Testing done

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

@CarbonDataQA
Copy link

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/469/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1734/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2117/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/486/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2132/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1750/

@manishgupta88 manishgupta88 changed the title [CARBONDATA-1592] Added TaskPreSubmitExecutionEvent for any operations to be done before submitting a task [CARBONDATA-1592] Add dictionary path support to carbondata Dec 7, 2017
@manishgupta88 manishgupta88 changed the title [CARBONDATA-1592] Add dictionary path support to carbondata [CARBONDATA-1870] Add dictionary path support to carbondata Dec 7, 2017
@CarbonDataQA
Copy link

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/566/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/575/

gvramana
gvramana reviewed Dec 7, 2017
View reviewed changes
.../main/java/org/apache/carbondata/core/cache/dictionary/DictionaryColumnUniqueIdentifier.java Outdated
@@ -79,21 +82,26 @@ public DictionaryColumnUniqueIdentifier(AbsoluteTableIdentifier absoluteTableIde
this.dataType = dataType;
if (null != carbonTablePath) {
this.carbonTablePath = carbonTablePath;
} else {
this.carbonTablePath = CarbonStorePath.getCarbonTablePath(absoluteTableIdentifier);
Copy link
Contributor

@gvramana gvramana Dec 7, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dictionaryLocation needs to be initialized here also, also in other constructors

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1814/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/586/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/589/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/591/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/593/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1821/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2191/

@gvramana
Copy link
Contributor

gvramana commented Dec 7, 2017

LGTM

@asfgit asfgit closed this in 29dc302 Dec 7, 2017
@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1825/

@manishgupta88 manishgupta88 deleted the preExecutorSubmitEvent branch December 12, 2017 05:45
jatin9896 pushed a commit to jatin9896/incubator-carbondata that referenced this pull request Jan 5, 2018
@manishgupta88 @jatin9896
[CARBONDATA-1870] Add dictionary path support to carbondata
ddf0a30 
This closes apache#1617
anubhav100 pushed a commit to anubhav100/incubator-carbondata that referenced this pull request Jun 22, 2018
@manishgupta88 @anubhav100
[CARBONDATA-1870] Add dictionary path support to carbondata
d722987 
This closes apache#1617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvramana gvramana gvramana left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manishgupta88 @CarbonDataQA @ravipesala @gvramana