-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CARBONDATA-1759]make visibility of segments as false eventhough file is not present To take care show segments after clean files operation #1627
Conversation
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/518/ |
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1777/ |
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2151/ |
retest sdv please |
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2166/ |
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/587/ |
52d0527
to
b88fe38
Compare
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/611/ |
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1839/ |
retest this please |
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/624/ |
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1852/ |
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2212/ |
oneLoad.setVisibility("false"); | ||
LOGGER.info("Info: Deleted the load " + oneLoad.getLoadName()); | ||
} | ||
physicalFactAndMeasureMetadataDeletion(path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While handling deletion in this method return true in case file does not exist and add a warning logger. As we dont have any other mechanism for clean up it will be good if we keep all the remaining code same and only set the status as true in case of non existence of file
…o take care show segments after clean files operation
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/655/ |
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1887/ |
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2234/ |
LGTM |
…e is not present in clean file operation Make visibility of segments as false eventhough file is not present to fix bug in show segments after clean files operation. This closes apache#1627
…e is not present in clean file operation Make visibility of segments as false eventhough file is not present to fix bug in show segments after clean files operation. This closes apache#1627
…e is not present in clean file operation Make visibility of segments as false eventhough file is not present to fix bug in show segments after clean files operation. This closes apache#1627
make visibility of segments as false eventhough file is not present To take care show segments after clean files operation
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
NA
Any backward compatibility impacted?
NA
Document update required?
NA
Testing done
test case is added in UT
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.