[CARBONDATA-1714] Fixed Issue for Selection of null values after having multiple alter commands #1629

jatin9896 · 2017-12-07T05:19:50Z

In CarbonTableInputFormat, isFilterMesure is populated with measurelist size as this includes the count of previous drop column having invisible true.

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

Any interfaces changed? No
Any backward compatibility impacted? No
Document update required? No
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required? No
- How it is tested? Please attach test report. NA
- Is it a performance related change? Please attach the performance test report. NA
- Any additional information to help reviewers in testing this change. NA
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

CarbonDataQA · 2017-12-07T06:09:50Z

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/543/

CarbonDataQA · 2017-12-07T06:57:54Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1800/

ravipesala · 2017-12-07T08:30:27Z

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2176/

ravipesala · 2017-12-07T09:11:36Z

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2177/

jatin9896 · 2017-12-08T07:16:10Z

retest this please

CarbonDataQA · 2017-12-08T07:49:21Z

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/616/

CarbonDataQA · 2017-12-08T07:56:08Z

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1844/

kumarvishal09 · 2017-12-14T10:57:29Z

@jatin9896 Can u please add a testcase for this scenario

jatin9896 · 2017-12-14T13:41:40Z

retest this please

jatin9896 · 2017-12-14T15:20:29Z

retest this please

CarbonDataQA · 2017-12-14T15:52:01Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1973/

CarbonDataQA · 2017-12-14T15:58:45Z

Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/745/

CarbonDataQA · 2017-12-14T16:20:39Z

Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/747/

CarbonDataQA · 2017-12-14T18:31:25Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1977/

ravipesala · 2017-12-14T20:04:59Z

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2293/

jatin9896 · 2017-12-15T04:53:44Z

retest this please

CarbonDataQA · 2017-12-15T05:03:18Z

Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/760/

CarbonDataQA · 2017-12-15T05:47:58Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1991/

jatin9896 · 2017-12-15T06:27:01Z

retest this please

CarbonDataQA · 2017-12-15T06:32:47Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1995/

CarbonDataQA · 2017-12-15T06:36:50Z

Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/765/

ravipesala · 2017-12-15T07:10:18Z

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2309/

jatin9896 · 2017-12-15T15:07:39Z

retest this please

CarbonDataQA · 2017-12-15T17:56:46Z

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/790/

ravipesala · 2017-12-15T21:09:24Z

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2335/

CarbonDataQA · 2017-12-15T21:17:32Z

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/798/

CarbonDataQA · 2017-12-15T21:26:52Z

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2024/

CarbonDataQA · 2017-12-16T02:20:53Z

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2031/

jatin9896 · 2017-12-16T02:34:27Z

@kumarvishal09 Please review.

kumarvishal09 · 2017-12-19T09:27:44Z

hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java

@@ -804,7 +804,7 @@ public QueryModel getQueryModel(InputSplit inputSplit, TaskAttemptContext taskAt
    Expression filter = getFilterPredicates(configuration);
    boolean[] isFilterDimensions = new boolean[carbonTable.getDimensionOrdinalMax()];
    boolean[] isFilterMeasures =
-        new boolean[carbonTable.getNumberOfMeasures(carbonTable.getTableName())];


Can u please add comment why you are calling getAllMeasures() instead of getNumberOfMeasures(carbonTable.getTableName())

getNumberOfMeasures doesn't include column count which was dropped but it exists in measure list with invisible true whereas the getAllmeasures also include the recent dropped column as well.

Please add comment in the code :)

done please review.

CarbonDataQA · 2017-12-19T18:03:38Z

Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/919/

ravipesala · 2017-12-19T19:26:49Z

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2432/

CarbonDataQA · 2017-12-19T22:25:35Z

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2150/

…commands

jatin9896 · 2017-12-20T06:51:59Z

retest this please

ravipesala · 2017-12-20T07:50:29Z

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2446/

jatin9896 · 2017-12-20T11:12:51Z

retest this please

CarbonDataQA · 2017-12-20T14:09:28Z

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/950/

CarbonDataQA · 2017-12-20T14:10:18Z

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2179/

kumarvishal09 · 2017-12-20T15:09:14Z

LGTM

…ng multiple alter commands In CarbonTableInputFormat, isFilterMesure is populated with measurelist size as this includes the count of previous drop column having invisible true. This closes apache#1629

jatin9896 force-pushed the CARBONDATA-1714 branch from 78a3077 to 75194e3 Compare December 7, 2017 05:27

jatin9896 force-pushed the CARBONDATA-1714 branch from 75194e3 to 8016dfd Compare December 14, 2017 13:03

jatin9896 force-pushed the CARBONDATA-1714 branch from 8016dfd to 0ccd994 Compare December 15, 2017 06:00

jatin9896 force-pushed the CARBONDATA-1714 branch from 0ccd994 to 7132e1e Compare December 15, 2017 13:14

kumarvishal09 reviewed Dec 19, 2017

View reviewed changes

jatin9896 force-pushed the CARBONDATA-1714 branch from 7132e1e to 9e1a0d8 Compare December 19, 2017 15:37

jatin9896 force-pushed the CARBONDATA-1714 branch from 9e1a0d8 to 16c6292 Compare December 20, 2017 05:16

fixed Issue for selection of null values after having multiple alter …

b64d524

…commands

jatin9896 force-pushed the CARBONDATA-1714 branch from 16c6292 to b64d524 Compare December 20, 2017 05:19

asfgit closed this in 64b2651 Dec 20, 2017

[CARBONDATA-1714] Fixed Issue for Selection of null values after having multiple alter commands #1629

[CARBONDATA-1714] Fixed Issue for Selection of null values after having multiple alter commands #1629

Conversation

jatin9896 commented Dec 7, 2017 • edited

CarbonDataQA commented Dec 7, 2017

CarbonDataQA commented Dec 7, 2017

ravipesala commented Dec 7, 2017

ravipesala commented Dec 7, 2017

jatin9896 commented Dec 8, 2017

CarbonDataQA commented Dec 8, 2017

CarbonDataQA commented Dec 8, 2017

kumarvishal09 commented Dec 14, 2017

jatin9896 commented Dec 14, 2017

jatin9896 commented Dec 14, 2017

CarbonDataQA commented Dec 14, 2017

CarbonDataQA commented Dec 14, 2017

CarbonDataQA commented Dec 14, 2017

CarbonDataQA commented Dec 14, 2017

ravipesala commented Dec 14, 2017

jatin9896 commented Dec 15, 2017

CarbonDataQA commented Dec 15, 2017

CarbonDataQA commented Dec 15, 2017

jatin9896 commented Dec 15, 2017

CarbonDataQA commented Dec 15, 2017

CarbonDataQA commented Dec 15, 2017

ravipesala commented Dec 15, 2017

jatin9896 commented Dec 15, 2017

CarbonDataQA commented Dec 15, 2017

ravipesala commented Dec 15, 2017

CarbonDataQA commented Dec 15, 2017

CarbonDataQA commented Dec 15, 2017

CarbonDataQA commented Dec 16, 2017

jatin9896 commented Dec 16, 2017 • edited

kumarvishal09 Dec 19, 2017 • edited

Choose a reason for hiding this comment

jatin9896 Dec 19, 2017

Choose a reason for hiding this comment

kumarvishal09 Dec 19, 2017

Choose a reason for hiding this comment

jatin9896 Dec 19, 2017

Choose a reason for hiding this comment

CarbonDataQA commented Dec 19, 2017

ravipesala commented Dec 19, 2017

CarbonDataQA commented Dec 19, 2017

jatin9896 commented Dec 20, 2017

ravipesala commented Dec 20, 2017

jatin9896 commented Dec 20, 2017

CarbonDataQA commented Dec 20, 2017

CarbonDataQA commented Dec 20, 2017

kumarvishal09 commented Dec 20, 2017

jatin9896 commented Dec 7, 2017 •

edited

jatin9896 commented Dec 16, 2017 •

edited

kumarvishal09 Dec 19, 2017 •

edited