Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-1881] Insert overwrite value for pre-aggregate load was incorrect #1639

Closed
wants to merge 1 commit into from

Conversation

kunal642
Copy link
Contributor

Analysis: while loading the value for insert overwrite was set to false.

Solution: Consider the value of insert overwrite set for maintable for pre-aggregate table loading.

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed?
    no

  • Any backward compatibility impacted?
    no

  • Document update required?
    no

  • Testing done
    Please provide details on
    - Whether new unit test cases have been added or why no new tests are required?
    - How it is tested? Please attach test report.
    - Is it a performance related change? Please attach the performance test report.
    - Any additional information to help reviewers in testing this change.

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/631/

@kunal642
Copy link
Contributor Author

Retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1860/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/633/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1862/

@ravipesala
Copy link
Contributor

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2205/

@kumarvishal09
Copy link
Contributor

LGTM

@kunal642
Copy link
Contributor Author

retest sdv please

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2237/

@asfgit asfgit closed this in c08fe93 Dec 13, 2017
kevinjmh pushed a commit to kevinjmh/carbondata that referenced this pull request Dec 13, 2017
…ncorrect

While loading the value for insert overwrite was set to false. Consider the value of insert overwrite set for maintable for pre-aggregate table loading.

This closes apache#1639
jatin9896 pushed a commit to jatin9896/incubator-carbondata that referenced this pull request Jan 5, 2018
…ncorrect

While loading the value for insert overwrite was set to false. Consider the value of insert overwrite set for maintable for pre-aggregate table loading.

This closes apache#1639
anubhav100 pushed a commit to anubhav100/incubator-carbondata that referenced this pull request Jun 22, 2018
…ncorrect

While loading the value for insert overwrite was set to false. Consider the value of insert overwrite set for maintable for pre-aggregate table loading.

This closes apache#1639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants