[CARBONDATA-1930] Added condition to refer to parent dictionary if filter is given in aggregate table query #1710
Conversation
kunal642
force-pushed
the
aggregate_filter_fix
branch
from
8b7570b
to
72aecee
Compare
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2259/ |
kunal642
force-pushed
the
aggregate_filter_fix
branch
from
72aecee
to
499d34c
Compare
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1037/ |
| if (null != tableProvider) { | ||
| CarbonTable carbonTable = tableProvider | ||
| .getCarbonTable(dictionarySourceAbsoluteTableIdentifier.getCarbonTableIdentifier()); | ||
| dictionaryPath = carbonTable.getTableInfo().getFactTable().getTableProperties() | ||
| .get(CarbonCommonConstants.DICTIONARY_PATH); | ||
| if (null != carbonDimension.getColumnSchema().getParentColumnTableRelations() && |
There was a problem hiding this comment.
here size check is also required when aggregate table is mapped to single parent column then only it will use table column dictionary otherwise it will use its own dictionary better to add a check size of parentcolumntablerelations is 1
…ggregate table query
kunal642
force-pushed
the
aggregate_filter_fix
branch
from
499d34c
to
302daeb
Compare
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2516/ |
|
LGTM |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2268/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1047/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2521/ |
…lter is given in aggregate table query When filter is applied to aggregate query then the query is not accessing the parent table dictionary instead it is trying to search for aggregate table dictionary files.Add check to access parent table dictionary files if aggregate column has parent columns. This closes apache#1710
…lter is given in aggregate table query When filter is applied to aggregate query then the query is not accessing the parent table dictionary instead it is trying to search for aggregate table dictionary files.Add check to access parent table dictionary files if aggregate column has parent columns. This closes apache#1710
…lter is given in aggregate table query When filter is applied to aggregate query then the query is not accessing the parent table dictionary instead it is trying to search for aggregate table dictionary files.Add check to access parent table dictionary files if aggregate column has parent columns. This closes apache#1710
Analysis: When filter is applied to aggregate query then the query is not accessing the parent table dictionary instead it is trying to search for aggregate table dictionary files.
Solution: Add check to access parent table dictionary files if aggregate column has parent columns.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
No
Any backward compatibility impacted?
No
Document update required?
No
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.