[CARBONDATA-1932] Add version for CarbonData #1714
Conversation
Add version for CarbonData
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2265/ |
|
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1044/ |
| /** | ||
| * current CarbonData version | ||
| */ | ||
| public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT"; |
There was a problem hiding this comment.
here, it is better to automatically get version number from pom file.
There was a problem hiding this comment.
I also think so, but I don't know how to implement it. I will try.
There was a problem hiding this comment.
I think you can do it as the same as spark, it generates a file called 'spark-version-info.properties' when build, and then read version information from this file at runtime.
There was a problem hiding this comment.
@zzcclp It has a little complexity in spark, is there better solution?
There was a problem hiding this comment.
I think it's a good way to do like spark, it's not complexity , I can help you to implement this.
There was a problem hiding this comment.
@zzcclp I assign the jira to you, and close this PR.
| import org.scalatest.BeforeAndAfterAll | ||
|
|
||
| /** | ||
| * Created by root on 12/22/17. |
|
why need to work on this pr ? |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2286/ |
|
retest this please |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2530/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1070/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2289/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1072/ |
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2300/ |
|
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1084/ |
|
@xubo245 why this version info is needed? |
|
When we test carbondata performance, we need know spark verison and carbondata version, like in concurrency test case. |
|
I assign the jira to @zzcclp , and close this PR. |
Add version for CarbonData
Are there any other good idea for CarbonData version?
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.