Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-1731,CARBONDATA-1728] Update,Delete fails incorrectly with error #1719

Closed
wants to merge 4 commits into from

Conversation

anubhav100
Copy link
Contributor

@anubhav100 anubhav100 commented Dec 22, 2017

[QueryExecution] Fetch BlockletId in Executor. Currently the blockletId are not propagated to the excutrs properly. Due to this reason the Implicit columns i.e. tupleId formed in executers can wrongly form duplicate tupleId. For e.g. a Block having two blocklets i.e. 0 and 1, in executors each tasks picks each blocklets. As the ID is not propagated each executor will term the Blocklets as ID 0. Solution is to propagate the Blocklet IDs to the executor from driver

@anubhav100 anubhav100 changed the title [CARBONDATA-1731,CARBONDATA-1728] Update fails incorrectly with error [WIP] [CARBONDATA-1731,CARBONDATA-1728] Update fails incorrectly with error Dec 22, 2017
@anubhav100 anubhav100 force-pushed the CARBONDATA-1731 branch 2 times, most recently from 79fb4cd to 52eeb56 Compare December 22, 2017 13:05
……These blockletId are not propagated to the excutrs properly. Due to this reason the Implicit columns i.e. tupleId formed

in executers can wrongly form duplicate tupleId. For e.g. a Block having two blocklets i.e. 0 and 1, in executors each
tasks picks each blocklets. As the ID is not propagated each executor will term the Blocklets as ID 0.
Solution is to propagate the Blocklet IDs to the executor from driver
* @param blockLength
* @param blockletInfos
*/
public TableBlockInfo(String filePath, String blockletIds, long blockOffset, String segmentId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo blockletId

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2275/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2522/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2524/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1054/

@anubhav100 anubhav100 changed the title [WIP] [CARBONDATA-1731,CARBONDATA-1728] Update fails incorrectly with error [CARBONDATA-1731,CARBONDATA-1728] Update fails incorrectly with error Dec 23, 2017
@anubhav100 anubhav100 changed the title [CARBONDATA-1731,CARBONDATA-1728] Update fails incorrectly with error [CARBONDATA-1731,CARBONDATA-1728] Update,Delete fails incorrectly with error Dec 23, 2017
@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2541/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1087/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2303/

@anubhav100
Copy link
Contributor Author

retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2305/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1089/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2542/

@ravipesala
Copy link
Contributor

LGTM

@asfgit asfgit closed this in 0c8fa59 Dec 27, 2017
SangeetaGulia pushed a commit to SangeetaGulia/incubator-carbondata that referenced this pull request Jan 3, 2018
…h error

[QueryExecution] Fetch BlockletId in Executor. Currently the blockletId are not propagated to the excutrs properly. Due to this reason the Implicit columns i.e. tupleId formed in executers can wrongly form duplicate tupleId. For e.g. a Block having two blocklets i.e. 0 and 1, in executors each tasks picks each blocklets. As the ID is not propagated each executor will term the Blocklets as ID 0. Solution is to propagate the Blocklet IDs to the executor from driver

This closes apache#1719
jatin9896 pushed a commit to jatin9896/incubator-carbondata that referenced this pull request Jan 5, 2018
…h error

[QueryExecution] Fetch BlockletId in Executor. Currently the blockletId are not propagated to the excutrs properly. Due to this reason the Implicit columns i.e. tupleId formed in executers can wrongly form duplicate tupleId. For e.g. a Block having two blocklets i.e. 0 and 1, in executors each tasks picks each blocklets. As the ID is not propagated each executor will term the Blocklets as ID 0. Solution is to propagate the Blocklet IDs to the executor from driver

This closes apache#1719
anubhav100 added a commit to anubhav100/incubator-carbondata that referenced this pull request Jun 22, 2018
…h error

[QueryExecution] Fetch BlockletId in Executor. Currently the blockletId are not propagated to the excutrs properly. Due to this reason the Implicit columns i.e. tupleId formed in executers can wrongly form duplicate tupleId. For e.g. a Block having two blocklets i.e. 0 and 1, in executors each tasks picks each blocklets. As the ID is not propagated each executor will term the Blocklets as ID 0. Solution is to propagate the Blocklet IDs to the executor from driver

This closes apache#1719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants