[CARBONDATA-264]Fixed limit query scan time statistics issue #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumarvishal09
force-pushed
the
statisticsissue
branch
from
60c92b0
to
5e2c8db
Compare
jackylk
reviewed
Oct 25, 2016
| @@ -36,6 +36,7 @@ | |||
| @Override public CarbonIterator<Object[]> execute(QueryModel queryModel) | |||
| throws QueryExecutionException { | |||
| List<BlockExecutionInfo> blockExecutionInfoList = getBlockExecutionInfos(queryModel); | |||
| queryProperties.scanStartTime=System.currentTimeMillis(); | |||
jackylk
reviewed
Oct 25, 2016
| @@ -91,5 +89,10 @@ | |||
| * list of blocks in which query will be executed | |||
| */ | |||
| protected List<AbstractIndex> dataBlocks; | |||
| /** | |||
| * start time scanning | |||
There was a problem hiding this comment.
it is the start time of scanning?
|
Build Failed, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/ |
Beyyes
pushed a commit
to Beyyes/carbondata
that referenced
this pull request
Jul 12, 2018
* fix bug * fix nodeGpuType empty string * fix user specified GPU atrribute not compatible with GPU type * fix bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Scan time is not logging in statistics in case of limit query
Soluntion: Moved statistics recording from iterator to queryExecutor finish method as in case of limit query after consuming records call is not coming to hasNext method