Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-2071] Added block size to BblockletDataMap while initialising #1851

Closed
wants to merge 2 commits into from

Conversation

ravipesala
Copy link
Contributor

Added block size to blocklet datamap so that features like small file merge can use them

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed?

  • Any backward compatibility impacted?

  • Document update required?

  • Testing done

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@ravipesala ravipesala changed the title [WIP]Added block size to DataMap while intializing [CARBONDATA-2071] Added block size to BblockletDataMap while initialising Jan 23, 2018
@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3065/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1833/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3069/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1838/

@ravipesala
Copy link
Contributor Author

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3054/

@ravipesala
Copy link
Contributor Author

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3059/

@QiangCai
Copy link
Contributor

verified on local standalone mode

LGTM

@@ -244,4 +247,22 @@ public void clearAccessCount(
cacheable.clear();
}
}

public static class BlockMetaInfo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only used in this class? I think it is better to move to outside if not just used in this class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


public static class BlockMetaInfo {
private String[] locationInfo;
private long size;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add comment for these two variable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3074/

@ravipesala
Copy link
Contributor Author

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3064/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1843/

@ravipesala
Copy link
Contributor Author

retest this please

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3078/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1847/

@QiangCai
Copy link
Contributor

verified CI successfully on local machine

@asfgit asfgit closed this in 44ffaf5 Jan 24, 2018
anubhav100 pushed a commit to anubhav100/incubator-carbondata that referenced this pull request Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants