[CARBONDATA-2070]fix create preaggregate on decimal column in hive metastore #1852
Conversation
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1832/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3064/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1837/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3068/ |
|
retest this please |
|
retest sdv please |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3055/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1840/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3071/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3058/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3061/ |
|
retest this please |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1844/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3075/ |
|
LGTM |
| @@ -210,6 +211,16 @@ class TestDataMapCommand extends QueryTest with BeforeAndAfterAll { | |||
| Seq(Row(1, 31), Row(2, 27), Row(3, 70), Row(4, 55))) | |||
| } | |||
|
|
|||
| test("test preaggregate load for decimal column for hivemetastore") { | |||
| CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_HIVE_SCHEMA_META_STORE, "true") | |||
| sql("drop datamap if exists uniqdata_agg on table uniqdata") | |||
…tastore Problem: when hive metastore is enabled and aggregate table is tried to create on the decimal column of main table, cast exception is thrown for Decimal datatype solution:During creation of TableInfo from hivemetastore the DataMapSchemas and the columns dataTypes are not converted to the appropriate child classes. convert to actual datatype This closes apache#1852
Problem: when hive metastore is enabled and aggregate table is tried to create on the decimal column of main table, cast exception is thrown for Decimal datatype
solution:During creation of TableInfo from hivemetastore the DataMapSchemas and the columns
dataTypes are not converted to the appropriate child classes.
convert to actual datatype
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
NA
Any backward compatibility impacted?
NA
Document update required?
NA
Testing done
Added UT
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
[] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.