[CARBONDATA-2090] Fix the error message of alter streaming property #1873
Conversation
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1970/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3205/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3169/ |
| @@ -182,6 +182,10 @@ class TestStreamingTableOperation extends QueryTest with BeforeAndAfterAll { | |||
|
|
|||
| // normal table not support streaming ingest | |||
| test("normal table not support streaming ingest") { | |||
There was a problem hiding this comment.
Please add alter table description for this test case
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3281/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2051/ |
QiangCai
force-pushed
the
streaming_property_set
branch
from
9221555
to
d8d00f4
Compare
|
retest this please |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3298/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2061/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3300/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2063/ |
|
retest this please |
|
LGTM, verified at my machine. |
Fix the error message of alter streaming property This closes apache#1873
For the streaming table, should prompt "Streaming property can not be changed once it is 'true'".
For the normal table, should prompt "Streaming property value is incorrect" if the value is not 'true'.
Any interfaces changed?
no
Any backward compatibility impacted?
no
Document update required?
no
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
ut added
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
small changes