[CARBONDATA-2224][File Level Reader Support] Refactoring of #2055 #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
changed the title
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3910/ |
|
Retest this please. |
|
Retest this please |
jackylk
reviewed
Mar 19, 2018
| import org.apache.hadoop.mapreduce.security.TokenCache; | ||
|
|
||
| /** | ||
| * Input format of CarbonData file. |
There was a problem hiding this comment.
change comment:
Base class for carbondata input format, there are two input format implementations:
1. CarbonFileInputFormat: describe this format
2. CarbonTableInputFormat: describe this format
jackylk
reviewed
Mar 19, 2018
| import org.apache.hadoop.mapreduce.lib.input.FileSplit; | ||
| import org.apache.hadoop.mapreduce.security.TokenCache; | ||
|
|
||
| /** | ||
| * Input format of CarbonData file. |
jackylk
reviewed
Mar 19, 2018
| import org.apache.hadoop.mapreduce.TaskAttemptContext; | ||
| import org.apache.hadoop.mapreduce.lib.input.FileInputFormat; | ||
| import org.apache.hadoop.mapreduce.lib.input.FileSplit; | ||
| import org.apache.hadoop.mapreduce.security.TokenCache; | ||
|
|
||
| /** | ||
| * Input format of CarbonData file. |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3938/ |
…arbondata into carbonfile_master # Conflicts: # hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java
|
retest this please |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3943/ |
|
retest this please |
|
add to whitelist |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3189/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4423/ |
ajantha-bhat
changed the title
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3946/ |
|
LGTM |
jackylk
pushed a commit
to jackylk/incubator-carbondata
that referenced
this pull request
Mar 21, 2018
Review comment fixes and refactoring of apache#2055 This closes apache#2069
anubhav100
pushed a commit
to anubhav100/incubator-carbondata
that referenced
this pull request
Apr 4, 2018
Review comment fixes and refactoring of apache#2055 This closes apache#2069
anubhav100
pushed a commit
to anubhav100/incubator-carbondata
that referenced
this pull request
Jun 22, 2018
Review comment fixes and refactoring of apache#2055 This closes apache#2069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review comment fixes and refactoring of #2055
CarbonTableInputFormat and CarbonFileInputFormat now extends CarbonInputFormat. This avoids the duplication of code.
And other minor review comment fixes on refactoring PR #2055
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.