[CARBONDATA-2277] fix for filter of default values on all datatypes #2102
Conversation
jatin9896
changed the title
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4575/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3349/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4073/ |
| "'1996/01/01 11:11:11')") | ||
| } | ||
| println("Timestamp Format: " + CarbonProperties.getInstance().getProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT)) | ||
| println("flag : "+ flag) |
There was a problem hiding this comment.
Remove all println statements
| checkAnswer(sql("select id from test where c3>='1995-01-01 11:11:11'"), | ||
| Seq(Row(3), Row(4), Row(1))) | ||
| checkAnswer(sql("select id from test where c3<='1995-01-02 11:11:11'"), Seq(Row(2),Row(3))) | ||
| CarbonProperties.getInstance() |
There was a problem hiding this comment.
enclose the test case in try and finally to ensure that the property getting set in try block gets unset in finally block
| checkAnswer(sql("select id from test where c3<34"), Seq(Row(1), Row(2))) | ||
| checkAnswer(sql("select id from test where c3>24"), Seq(Row(2), Row(3), Row(4))) | ||
| checkAnswer(sql("select id from test where c3>=35"), Seq(Row(3), Row(4))) | ||
| checkAnswer(sql("select id from test where c3<=35"), Seq(Row(1), Row(2), Row(3))) |
There was a problem hiding this comment.
Add a query for !=, null and not null cases also
jatin9896
force-pushed
the
CARBONDATA-2277
branch
from
c4bc631
to
a939e0c
Compare
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3416/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4151/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4641/ |
|
LGTM |
1. Added solution to handle filter keys for the direct dictionary on default values. 2. For no dictionary columns changes code to get correct bytes value of default values. This closes #2102
1. Added solution to handle filter keys for the direct dictionary on default values. 2. For no dictionary columns changes code to get correct bytes value of default values. This closes apache#2102
1. Added solution to handle filter keys for the direct dictionary on default values. 2. For no dictionary columns changes code to get correct bytes value of default values. This closes apache#2102
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed? No
Any backward compatibility impacted? No
Document update required? No
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required? Yes
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.