[CARBONDATA-2335] Fix auto handoff for preaggregate table with streaming #2160
Conversation
kunal642
force-pushed
the
fix_auto_handoff_aggregate_load
branch
from
f6bc577
to
cf18bd7
Compare
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3732/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3733/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4407/ |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4951/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4408/ |
|
retest this please |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4969/ |
|
retest this please |
|
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5048/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3830/ |
| @@ -163,7 +162,7 @@ class CarbonAppendableStreamSink( | |||
| /** | |||
| * if the directory size of current segment beyond the threshold, hand off new segment | |||
| */ | |||
| private def checkOrHandOffSegment(): Unit = { | |||
| private def checkOrHandOffSegment(operationContext: OperationContext): Unit = { | |||
There was a problem hiding this comment.
No need to change method signature use the same operation context passed in CarbonAppendableStreamSink
| @@ -110,6 +110,8 @@ object StreamSinkFactory { | |||
| val segmentId = getStreamSegmentId(carbonTable) | |||
| carbonLoadModel.setSegmentId(segmentId) | |||
|
|
|||
| val loadMetaEvent = new LoadMetadataEvent(carbonTable, false) | |||
| OperationListenerBus.getInstance().fireEvent(loadMetaEvent, operationContext) | |||
kunal642
force-pushed
the
fix_auto_handoff_aggregate_load
branch
from
cf18bd7
to
1dc9b4c
Compare
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3842/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5064/ |
|
retest this please |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3854/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5076/ |
|
LGTM |
Solution: MetaListener was not called for auto handoff case therefore child load commands were not being created thus throwing NullPointerException. This closes apache#2160
Solution: MetaListener was not called for auto handoff case therefore child load commands were not being created thus throwing NullPointerException.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.